From: Al Viro <viro@ZenIV.linux.org.uk>
To: John Fastabend <john.r.fastabend@intel.com>
Cc: nhorman@tuxdriver.com, netdev@vger.kernel.org,
davem@davemloft.net, linux-kernel@vger.kernel.org,
joe@perches.com
Subject: Re: [net PATCH v1 2/2] net: netprio: fd passed in SCM_RIGHTS datagram not set correctly
Date: Tue, 14 Aug 2012 03:31:28 +0100 [thread overview]
Message-ID: <20120814023128.GG23464@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120814013944.3144.53854.stgit@jf-dev1-dcblab>
On Mon, Aug 13, 2012 at 06:39:45PM -0700, John Fastabend wrote:
> /* Bump the usage count and install the file. */
> get_file(fp[i]);
> fd_install(new_fd, fp[i]);
> + sock = sock_from_file(fp[i], &err);
> + if (sock)
> + sock->sk->sk_cgrp_prioidx = prioidx;
Better to do that before fd_install() exposes the sucker; it's not
a serious issue, but it's more obviously correct that way.
next prev parent reply other threads:[~2012-08-14 2:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 1:39 [net PATCH v1 1/2] net: netprio: fix files lock and remove useless d_path bits John Fastabend
2012-08-14 1:39 ` [net PATCH v1 2/2] net: netprio: fd passed in SCM_RIGHTS datagram not set correctly John Fastabend
2012-08-14 2:31 ` Al Viro [this message]
2012-08-14 3:00 ` John Fastabend
2012-08-14 2:29 ` [net PATCH v1 1/2] net: netprio: fix files lock and remove useless d_path bits Al Viro
2012-08-14 2:59 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120814023128.GG23464@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=john.r.fastabend@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).