linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>,
	linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Felipe Balbi <balbi@ti.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCHv2 2/4] arm/dts: omap5-evm: Add tmp102 sensor support
Date: Tue, 14 Aug 2012 12:59:26 +0300	[thread overview]
Message-ID: <20120814095923.GB11416@arwen.pp.htv.fi> (raw)
In-Reply-To: <502A20DD.5030707@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1905 bytes --]

On Tue, Aug 14, 2012 at 11:56:45AM +0200, Benoit Cousson wrote:
> On 08/13/2012 12:05 PM, Sourav Poddar wrote:
> > Add tmp102 temperature sensor data in omap5 evm dts file.
> > 
> > Tested on omap5430 evm with 3.5 custom kernel.
> > 
> > Cc: Benoit Cousson <b-cousson@ti.com>
> > Cc: Felipe Balbi <balbi@ti.com>
> > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > Acked-by: Felipe Balbi <balbi@ti.com>
> > Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> > ---
> >  arch/arm/boot/dts/omap5-evm.dts |    9 +++++++++
> >  1 files changed, 9 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/omap5-evm.dts b/arch/arm/boot/dts/omap5-evm.dts
> > index 200c39a..45a8aeb 100644
> > --- a/arch/arm/boot/dts/omap5-evm.dts
> > +++ b/arch/arm/boot/dts/omap5-evm.dts
> > @@ -18,3 +18,12 @@
> >  		reg = <0x80000000 0x40000000>; /* 1 GB */
> >  	};
> >  };
> > +
> > +&i2c4 {
> > +	clock-frequency = <400000>;
> 
> Have you checked if we cannot run at faster speed? Reducing the speed
> will impact every devices on the bus.
> It might be needed, I just wanted to be sure.
> 
> You should maybe just add a small comment to explain what the device is
> doing with potentially a link to the HW spec if available.
> 
> The same comments are applicable to the bmp085 patch.

that sort of information should be placed on
Documentation/devicetree/bindings/*/$device.txt, right ? Why should we
replicate it on all dts files ? Besides, there are only two such entries
on all ARM DTS files. Do we really want to make dts files bigger with
links to documentation which can even be moved at any time to other
location by the manufacturer's choice ? Will anyone actually keep track
of such links to make sure they aren't broken ? And even if someone does
track those links, do we really want to keep sending such patches for
the dts files ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-08-14 10:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-13 10:05 [PATCHv2 0/4] Add device tree data for omap5 Sourav Poddar
2012-08-13 10:05 ` [PATCHv2 1/4] arm/dts: omap5-evm: Add I2C support Sourav Poddar
2012-08-13 10:05 ` [PATCHv2 2/4] arm/dts: omap5-evm: Add tmp102 sensor support Sourav Poddar
2012-08-14  9:56   ` Benoit Cousson
2012-08-14  9:59     ` Felipe Balbi [this message]
2012-08-14 10:21       ` Benoit Cousson
2012-08-14 10:27     ` Poddar, Sourav
2012-08-13 10:05 ` [PATCH 3/4] arm/dts: omap5-evm: Add keypad data Sourav Poddar
2012-08-13 10:05 ` [PATCH 4/4] arm/dts: omap5-evm: Add bmp085 sensor support Sourav Poddar
2012-08-13 11:39 ` [PATCHv2 0/4] Add device tree data for omap5 Shilimkar, Santosh
2012-08-14 10:24 ` Benoit Cousson
2012-08-14 10:34   ` Poddar, Sourav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120814095923.GB11416@arwen.pp.htv.fi \
    --to=balbi@ti.com \
    --cc=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    --cc=sourav.poddar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).