From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755920Ab2HOQqH (ORCPT ); Wed, 15 Aug 2012 12:46:07 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:40986 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755868Ab2HOQqF (ORCPT ); Wed, 15 Aug 2012 12:46:05 -0400 Date: Wed, 15 Aug 2012 17:45:30 +0100 From: Catalin Marinas To: Geert Uytterhoeven Cc: Arnd Bergmann , "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Will Deacon Subject: Re: [PATCH v2 04/31] arm64: MMU definitions Message-ID: <20120815164529.GB14264@arm.com> References: <1344966752-16102-1-git-send-email-catalin.marinas@arm.com> <1344966752-16102-5-git-send-email-catalin.marinas@arm.com> <201208151330.02112.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 15, 2012 at 05:34:46PM +0100, Geert Uytterhoeven wrote: > On Wed, Aug 15, 2012 at 3:30 PM, Arnd Bergmann wrote: > >> +#define TCR_IPS_40BIT (2 << 32) > > By default, constants are int, i.e. 32-bit. So you must write > > 2ULL << 32 > > >> +#define TCR_ASID16 (1 << 36) > > 1ULL Those higher constants are only used in assembly currently, so no side-effects. But I agree that I should use something like: (_AC(1, UL) << 36) (UL is sufficient on a 64-bit system) Thanks. -- Catalin