From: "J. Bruce Fields" <bfields@fieldses.org>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Emelyanov <xemul@parallels.com>,
James Bottomley <jbottomley@parallels.com>,
Matthew Helsley <matt.helsley@gmail.com>
Subject: Re: [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper
Date: Wed, 15 Aug 2012 16:45:46 -0400 [thread overview]
Message-ID: <20120815204546.GC25062@fieldses.org> (raw)
In-Reply-To: <20120815092409.591460800@openvz.org>
On Wed, Aug 15, 2012 at 01:21:20PM +0400, Cyrill Gorcunov wrote:
> To provide fsnotify object inodes being watched without
> binding to alphabetical path we need to encode them with
> exportfs help. This patch adds a helper which operates
> with plain inodes directly.
I don't get it--this seems like a really roundabout way to get inode and
generation number, if that's all you want.
On the other hand, if you want a real filehandle then wouldn't you want
to e.g. call the filesystem's ->encode_fh() if necessary, as
exportfs_encode_fh() does?
--b.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> Acked-by: Pavel Emelyanov <xemul@parallels.com>
> CC: Al Viro <viro@ZenIV.linux.org.uk>
> CC: Alexey Dobriyan <adobriyan@gmail.com>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: James Bottomley <jbottomley@parallels.com>
> ---
> fs/exportfs/expfs.c | 19 +++++++++++++++++++
> include/linux/exportfs.h | 2 ++
> 2 files changed, 21 insertions(+)
>
> Index: linux-2.6.git/fs/exportfs/expfs.c
> ===================================================================
> --- linux-2.6.git.orig/fs/exportfs/expfs.c
> +++ linux-2.6.git/fs/exportfs/expfs.c
> @@ -302,6 +302,25 @@ out:
> return error;
> }
>
> +int export_encode_inode_fh(struct inode *inode, struct fid *fid, int *max_len)
> +{
> + int len = *max_len;
> + int type = FILEID_INO32_GEN;
> +
> + if (len < 2) {
> + *max_len = 2;
> + return 255;
> + }
> +
> + len = 2;
> + fid->i32.ino = inode->i_ino;
> + fid->i32.gen = inode->i_generation;
> + *max_len = len;
> +
> + return type;
> +}
> +EXPORT_SYMBOL_GPL(export_encode_inode_fh);
> +
> /**
> * export_encode_fh - default export_operations->encode_fh function
> * @inode: the object to encode
> Index: linux-2.6.git/include/linux/exportfs.h
> ===================================================================
> --- linux-2.6.git.orig/include/linux/exportfs.h
> +++ linux-2.6.git/include/linux/exportfs.h
> @@ -177,6 +177,8 @@ struct export_operations {
> int (*commit_metadata)(struct inode *inode);
> };
>
> +extern int export_encode_inode_fh(struct inode *inode, struct fid *fid, int *max_len);
> +
> extern int exportfs_encode_fh(struct dentry *dentry, struct fid *fid,
> int *max_len, int connectable);
> extern struct dentry *exportfs_decode_fh(struct vfsmount *mnt, struct fid *fid,
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-08-15 20:45 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 9:21 [patch 0/8] procfs, fdinfo updated Cyrill Gorcunov
2012-08-15 9:21 ` [patch 1/8] procfs: Move /proc/pid/fd[info] handling code to fd.[ch] Cyrill Gorcunov
2012-08-15 9:21 ` [patch 2/8] procfs: Convert /proc/pid/fdinfo/ handling routines to seq-file Cyrill Gorcunov
2012-08-15 9:21 ` [patch 3/8] procfs: Add ability to plug in auxiliary fdinfo providers Cyrill Gorcunov
2012-08-15 21:16 ` Al Viro
2012-08-15 21:31 ` Cyrill Gorcunov
2012-08-15 21:29 ` Al Viro
2012-08-15 21:34 ` Cyrill Gorcunov
2012-08-16 10:58 ` Cyrill Gorcunov
2012-08-15 9:21 ` [patch 4/8] fs, exportfs: Add export_encode_inode_fh helper Cyrill Gorcunov
2012-08-15 20:45 ` J. Bruce Fields [this message]
2012-08-15 21:02 ` Cyrill Gorcunov
2012-08-15 22:06 ` J. Bruce Fields
2012-08-16 6:24 ` Cyrill Gorcunov
2012-08-16 12:38 ` Cyrill Gorcunov
2012-08-16 12:47 ` J. Bruce Fields
2012-08-16 13:16 ` Cyrill Gorcunov
2012-08-16 14:57 ` Cyrill Gorcunov
2012-08-16 15:05 ` Al Viro
2012-08-16 15:09 ` Cyrill Gorcunov
2012-08-16 13:43 ` Al Viro
2012-08-16 13:47 ` Pavel Emelyanov
2012-08-16 13:50 ` Al Viro
2012-08-16 13:53 ` Pavel Emelyanov
2012-08-16 13:54 ` Cyrill Gorcunov
2012-08-16 14:03 ` James Bottomley
2012-08-16 14:13 ` Pavel Emelyanov
2012-08-16 14:15 ` Cyrill Gorcunov
2012-08-16 14:41 ` Al Viro
2012-08-16 14:48 ` Cyrill Gorcunov
2012-08-16 14:54 ` J. Bruce Fields
2012-08-16 14:55 ` Al Viro
2012-08-16 15:06 ` Pavel Emelyanov
2012-08-16 15:35 ` Cyrill Gorcunov
2012-08-16 15:07 ` Cyrill Gorcunov
2012-08-17 20:58 ` Eric W. Biederman
2012-08-16 13:48 ` Al Viro
2012-08-20 14:19 ` Aneesh Kumar K.V
2012-08-20 16:33 ` Cyrill Gorcunov
2012-08-20 18:32 ` J. Bruce Fields
2012-08-20 19:06 ` Cyrill Gorcunov
2012-08-20 19:32 ` J. Bruce Fields
2012-08-20 19:40 ` Cyrill Gorcunov
2012-08-21 9:18 ` Pavel Emelyanov
2012-08-21 10:42 ` Aneesh Kumar K.V
2012-08-21 10:49 ` Pavel Emelyanov
2012-08-21 10:54 ` Cyrill Gorcunov
2012-08-21 11:09 ` Pavel Emelyanov
2012-08-21 12:11 ` J. Bruce Fields
2012-08-21 12:22 ` Pavel Emelyanov
2012-08-21 12:29 ` J. Bruce Fields
2012-08-21 12:40 ` Pavel Emelyanov
2012-08-21 12:51 ` Boaz Harrosh
2012-08-21 12:59 ` Pavel Emelyanov
2012-08-21 13:08 ` Boaz Harrosh
2012-08-21 13:12 ` Al Viro
2012-08-21 13:40 ` Cyrill Gorcunov
2012-08-21 12:09 ` J. Bruce Fields
2012-08-21 12:25 ` Pavel Emelyanov
2012-08-22 5:49 ` Aneesh Kumar K.V
2012-08-23 8:06 ` Cyrill Gorcunov
2012-08-23 8:54 ` Marco Stornelli
2012-08-23 9:29 ` Cyrill Gorcunov
2012-08-15 9:21 ` [patch 5/8] fs, notify: Add procfs fdinfo helper v3 Cyrill Gorcunov
2012-08-15 9:21 ` [patch 6/8] fs, eventfd: Add procfs fdinfo helper Cyrill Gorcunov
2012-08-15 9:21 ` [patch 7/8] fs, epoll: Add procfs fdinfo helper v2 Cyrill Gorcunov
2012-08-15 9:21 ` [patch 8/8] fdinfo: Show sigmask for signalfd fd v2 Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815204546.GC25062@fieldses.org \
--to=bfields@fieldses.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=jbottomley@parallels.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.helsley@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).