From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755729Ab2HPOjB (ORCPT ); Thu, 16 Aug 2012 10:39:01 -0400 Received: from mail-qa0-f46.google.com ([209.85.216.46]:41646 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751957Ab2HPOjA (ORCPT ); Thu, 16 Aug 2012 10:39:00 -0400 Date: Thu, 16 Aug 2012 16:38:53 +0200 From: Frederic Weisbecker To: Martin Schwidefsky Cc: Benjamin Herrenschmidt , Ingo Molnar , Thomas Gleixner , LKML , Tony Luck , Fenghua Yu , Paul Mackerras , Heiko Carstens , Peter Zijlstra Subject: Re: [PATCH 1/4] cputime: Generalize CONFIG_VIRT_CPU_ACCOUNTING Message-ID: <20120816143851.GI19716@somewhere> References: <1344953810-20564-1-git-send-email-fweisbec@gmail.com> <1344953810-20564-2-git-send-email-fweisbec@gmail.com> <20120815170347.323507b1@de.ibm.com> <20120815190901.GD19716@somewhere> <20120816095336.4eeb3ce1@de.ibm.com> <1345109897.11751.31.camel@pasglop> <20120816125556.GG19716@somewhere> <20120816160044.1941f6f4@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120816160044.1941f6f4@de.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 16, 2012 at 04:00:44PM +0200, Martin Schwidefsky wrote: > On Thu, 16 Aug 2012 14:55:59 +0200 > Frederic Weisbecker wrote: > > > On Thu, Aug 16, 2012 at 07:38:17PM +1000, Benjamin Herrenschmidt wrote: > > > On Thu, 2012-08-16 at 09:53 +0200, Martin Schwidefsky wrote: > > > > Hmm, ok. But then the description should be reworded not to be specific to > > > > the power architecture (the part of the message about "This also enables > > > > accounting of stolen time on logically-partitioned systems running on IBM > > > > POWER5-based machines."). > > > > > > Which is not very helpful to somebody running on a POWER6 or 7 (which > > > also support that option just fine :-) > > > > > > So yes, the description should definitely be improved. > > > > All right. How about something like the below? > > > > diff --git a/init/Kconfig b/init/Kconfig > > index 894b073..5f5f8c2 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -276,9 +276,9 @@ config VIRT_CPU_ACCOUNTING > > accounting. This is done by reading a CPU counter on each > > kernel entry and exit and on transitions within the kernel > > between system, softirq and hardirq state, so there is a > > - small performance impact. This also enables accounting of > > - stolen time on logically-partitioned systems running on > > - IBM POWER5-based machines. > > + small performance impact. In the case of IBM POWER > 5, this > > + also enables accounting of stolen time on logically-partitioned > > + systems. > > > > config BSD_PROCESS_ACCT > > bool "BSD Process Accounting" > > > > VIRT_CPU_ACCOUNTING will enable steal time for s390 as well. Ah right. Fixed below: diff --git a/init/Kconfig b/init/Kconfig index 894b073..c40d0fb 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -276,9 +276,9 @@ config VIRT_CPU_ACCOUNTING accounting. This is done by reading a CPU counter on each kernel entry and exit and on transitions within the kernel between system, softirq and hardirq state, so there is a - small performance impact. This also enables accounting of - stolen time on logically-partitioned systems running on - IBM POWER5-based machines. + small performance impact. In the case of s390 or IBM POWER > 5, + this also enables accounting of stolen time on logically-partitioned + systems. config BSD_PROCESS_ACCT bool "BSD Process Accounting"