From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Paul Mackerras <paulus@samba.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/4] cputime: Generalize CONFIG_VIRT_CPU_ACCOUNTING
Date: Thu, 16 Aug 2012 16:00:44 +0200 [thread overview]
Message-ID: <20120816160044.1941f6f4@de.ibm.com> (raw)
In-Reply-To: <20120816125556.GG19716@somewhere>
On Thu, 16 Aug 2012 14:55:59 +0200
Frederic Weisbecker <fweisbec@gmail.com> wrote:
> On Thu, Aug 16, 2012 at 07:38:17PM +1000, Benjamin Herrenschmidt wrote:
> > On Thu, 2012-08-16 at 09:53 +0200, Martin Schwidefsky wrote:
> > > Hmm, ok. But then the description should be reworded not to be specific to
> > > the power architecture (the part of the message about "This also enables
> > > accounting of stolen time on logically-partitioned systems running on IBM
> > > POWER5-based machines.").
> >
> > Which is not very helpful to somebody running on a POWER6 or 7 (which
> > also support that option just fine :-)
> >
> > So yes, the description should definitely be improved.
>
> All right. How about something like the below?
>
> diff --git a/init/Kconfig b/init/Kconfig
> index 894b073..5f5f8c2 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -276,9 +276,9 @@ config VIRT_CPU_ACCOUNTING
> accounting. This is done by reading a CPU counter on each
> kernel entry and exit and on transitions within the kernel
> between system, softirq and hardirq state, so there is a
> - small performance impact. This also enables accounting of
> - stolen time on logically-partitioned systems running on
> - IBM POWER5-based machines.
> + small performance impact. In the case of IBM POWER > 5, this
> + also enables accounting of stolen time on logically-partitioned
> + systems.
>
> config BSD_PROCESS_ACCT
> bool "BSD Process Accounting"
>
VIRT_CPU_ACCOUNTING will enable steal time for s390 as well.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2012-08-16 14:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 14:16 [PATCH 0/4] cputime: Virtual cputime accounting small cleanups and consolidation v2 Frederic Weisbecker
2012-08-14 14:16 ` [PATCH 1/4] cputime: Generalize CONFIG_VIRT_CPU_ACCOUNTING Frederic Weisbecker
2012-08-15 15:03 ` Martin Schwidefsky
2012-08-15 19:09 ` Frederic Weisbecker
2012-08-16 7:53 ` Martin Schwidefsky
2012-08-16 9:38 ` Benjamin Herrenschmidt
2012-08-16 12:55 ` Frederic Weisbecker
2012-08-16 14:00 ` Martin Schwidefsky [this message]
2012-08-16 14:38 ` Frederic Weisbecker
2012-08-14 14:16 ` [PATCH 2/4] sched: Move cputime code to its own file Frederic Weisbecker
2012-08-15 15:07 ` Martin Schwidefsky
2012-08-14 14:16 ` [PATCH 3/4] cputime: Consolidate vtime handling on context switch Frederic Weisbecker
2012-08-15 15:22 ` Martin Schwidefsky
2012-08-15 19:28 ` Frederic Weisbecker
2012-08-16 7:50 ` Martin Schwidefsky
2012-08-16 12:50 ` Frederic Weisbecker
2012-08-16 13:59 ` Martin Schwidefsky
2012-08-14 14:16 ` [PATCH 4/4] s390: Remove leftover account_tick_vtime() header Frederic Weisbecker
2012-08-15 15:22 ` Martin Schwidefsky
2012-08-15 4:54 ` [PATCH 0/4] cputime: Virtual cputime accounting small cleanups and consolidation v2 Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2012-08-17 14:37 [PATCH 0/4] cputime: Virtual cputime accounting small cleanups and consolidation v3 Frederic Weisbecker
2012-08-17 14:37 ` [PATCH 1/4] cputime: Generalize CONFIG_VIRT_CPU_ACCOUNTING Frederic Weisbecker
2012-06-19 13:43 [PATCH 0/4] cputime: Virtual cputime accounting small cleanups and consolidation Frederic Weisbecker
2012-06-19 13:43 ` [PATCH 1/4] cputime: Generalize CONFIG_VIRT_CPU_ACCOUNTING Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816160044.1941f6f4@de.ibm.com \
--to=schwidefsky@de.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=fenghua.yu@intel.com \
--cc=fweisbec@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).