From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758378Ab2HQQQL (ORCPT ); Fri, 17 Aug 2012 12:16:11 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:38154 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758337Ab2HQQQB (ORCPT ); Fri, 17 Aug 2012 12:16:01 -0400 Date: Fri, 17 Aug 2012 17:15:28 +0100 From: Catalin Marinas To: Arnd Bergmann Cc: "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Will Deacon Subject: Re: [PATCH v2 07/31] arm64: Process management Message-ID: <20120817161528.GK24389@arm.com> References: <1344966752-16102-1-git-send-email-catalin.marinas@arm.com> <1344966752-16102-8-git-send-email-catalin.marinas@arm.com> <201208151353.01367.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201208151353.01367.arnd@arndb.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 15, 2012 at 02:53:01PM +0100, Arnd Bergmann wrote: > On Tuesday 14 August 2012, Catalin Marinas wrote: > > > +#define THREAD_SIZE_ORDER 1 > > +#define THREAD_SIZE 8192 > > +#define THREAD_START_SP (THREAD_SIZE - 16) > > THREAD_SIZE_ORDER looks wrong for 64kb-page kernels. It also doesn't seem to > be used, so better remove it. It's used in kernel/fork.c if THREAD_SIZE >= PAGE_SIZE. I'll define it conditionally. -- Catalin