From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Ming Lei <ming.lei@canonical.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Borislav Petkov <borislav.petkov@amd.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v1 2/3] PM / Sleep: introduce dpm_for_each_dev
Date: Sat, 18 Aug 2012 22:33:36 +0200 [thread overview]
Message-ID: <201208182233.37188.rjw@sisk.pl> (raw)
In-Reply-To: <CACVXFVMxGCGJ+a=rfcCAqRuUMLG9OD3X52MMzTcfYOT4cepBGQ@mail.gmail.com>
On Saturday, August 18, 2012, Ming Lei wrote:
> On Sat, Aug 18, 2012 at 9:38 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >
> > My question was about the number of current users of it. Sorry for not
> > being clear.
>
> Sorry for misunderstanding your question.
>
> >
> > If there are no more anticipated users than the current only one, please
> > drop the unused (void *) argument. We can always extend it in the future
> > if need be and for now passing that NULL every time is just pointless.
>
> One usage is to get statistics info about devices for debug purpose,
> so the parameter is needed to return something.
So, what's the name of the _second_ function using dpm_for_each_dev()?
I don't see any and device_cache_fw_images() in [3/3] clearly passes
NULL as the first argument.
> > And please fold [2/3] into [3/3] in this series.
>
> IMO, it is better to split them to avoid coupling between fw loader and
> device PM.
>
> Looks you agreed on the patch,
On the idea, not on the actual code. I told you what I wanted to to change in
it, didn't I?
> and Greg has added the
> patch into his driver-core next tree to fix -next build failure, so could
> you just let them be that?
-next is not cast in stone, you can replace patches in it with other ones
if need be.
Thanks,
Rafael
next prev parent reply other threads:[~2012-08-18 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 14:06 [PATCH v1 0/3] firmware loader: fix build failure Ming Lei
2012-08-17 14:06 ` [PATCH v1 1/3] firmware loader: fix compile failure if !PM Ming Lei
2012-08-17 14:06 ` [PATCH v1 2/3] PM / Sleep: introduce dpm_for_each_dev Ming Lei
2012-08-17 22:02 ` Rafael J. Wysocki
2012-08-18 0:43 ` Ming Lei
2012-08-18 13:38 ` Rafael J. Wysocki
2012-08-18 14:52 ` Ming Lei
2012-08-18 20:33 ` Rafael J. Wysocki [this message]
2012-08-18 20:49 ` Rafael J. Wysocki
2012-08-19 6:20 ` Greg Kroah-Hartman
2012-08-19 20:10 ` Rafael J. Wysocki
2012-08-17 14:07 ` [PATCH v1 3/3] firmware loader: fix build failure if FW_LOADER is m Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208182233.37188.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=borislav.petkov@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).