From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754802Ab2HTIgu (ORCPT ); Mon, 20 Aug 2012 04:36:50 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:57514 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753300Ab2HTIgs (ORCPT ); Mon, 20 Aug 2012 04:36:48 -0400 Date: Mon, 20 Aug 2012 09:36:43 +0100 From: Lee Jones To: Linus Walleij Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, broonie@opensource.wolfsonmicro.com, Samuel Ortiz Subject: Re: [PATCH 5/8] mfd: Provide the PRCMU with its own IRQ domain Message-ID: <20120820083640.GH8450@gmail.com> References: <1344527635-6163-1-git-send-email-lee.jones@linaro.org> <1344527635-6163-6-git-send-email-lee.jones@linaro.org> <201208140942.54773.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 14, 2012 at 12:44:37PM +0200, Linus Walleij wrote: > On Tue, Aug 14, 2012 at 11:42 AM, Arnd Bergmann wrote: > > On Tuesday 14 August 2012, Linus Walleij wrote: > >> On Thu, Aug 9, 2012 at 5:53 PM, Lee Jones wrote: > >> > >> > +int db8500_irq_get_virq(int irq); > >> > >> And I'm sceptic about this business. Why isn't this physical-to virtual > >> mapping business confined to the core MFD driver? But enlighten me. > > > > Traditionally, an MFD would add an offset to the local IRQ number > > to put the VIRQ into the IRQ resource, but this doesn't work when > > you have domains other than legacy. > > Yes but I think I saw this other patch set from Lee, hitting > irqdomain, OF and MFD to actually fix this ... or did I get > it wrong? No, you're not wrong. Historically (in my patches) xb8500_irq_get_virq() was used by drivers to obtain a VIRQ when not using Device Tree. Now the MFD core handles conversion there is little requirement for it. In fact there are no more users for db8500_irq_get_virq() and only one user for ab8500_irq_get_virq() and that's itself. I guess we can rid them and call irq_get_mapping() directly instead. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog