From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756251Ab2HTJgu (ORCPT ); Mon, 20 Aug 2012 05:36:50 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:33292 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905Ab2HTJgq (ORCPT ); Mon, 20 Aug 2012 05:36:46 -0400 Date: Mon, 20 Aug 2012 10:36:40 +0100 From: Lee Jones To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, broonie@opensource.wolfsonmicro.com, Samuel Ortiz Subject: Re: [PATCH 5/8] mfd: Provide the PRCMU with its own IRQ domain Message-ID: <20120820093638.GK8450@gmail.com> References: <1344527635-6163-1-git-send-email-lee.jones@linaro.org> <1344527635-6163-6-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 14, 2012 at 10:29:14AM +0200, Linus Walleij wrote: > On Thu, Aug 9, 2012 at 5:53 PM, Lee Jones wrote: > > > +static struct irq_domain *db8500_irq_domain; > > So this is a good idea. Did you mean this, or did you mean that it's _not_ a good idea? If the latter is true, where would you prefer to see it? > > +int db8500_irq_get_virq(int irq); > > And I'm sceptic about this business. Why isn't this physical-to virtual > mapping business confined to the core MFD driver? But enlighten me. > > Yours, > Linus Walleij -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog