From: Mike Snitzer <snitzer@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Shaohua Li <shli@kernel.org>, Vivek Goyal <vgoyal@redhat.com>,
axboe@kernel.dk, linux-kernel@vger.kernel.org, neilb@suse.de,
linux-scsi@vger.kernel.org
Subject: Re: [patch 1/2]block: handle merged discard request
Date: Mon, 20 Aug 2012 09:57:39 -0400 [thread overview]
Message-ID: <20120820135739.GB28570@redhat.com> (raw)
In-Reply-To: <yq1wr0weu9q.fsf@sermon.lab.mkp.net>
On Fri, Aug 17 2012 at 11:47pm -0400,
Martin K. Petersen <martin.petersen@oracle.com> wrote:
> >>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:
>
> Mike> Could be I've wasted a few hours by rebasing these patches...
> Mike> regardless, it would be great if you could share what your plans
> Mike> are.
>
> Heh, I worked on syncing my patch queue up to Jens' and James' trees
> this afternoon. But I didn't quite finish the block stuff, mainly due to
> some conflicts with a few topology changes I also have pending.
>
> I'll take a look at your series. Maybe I'll swap things around and put
> the topology changes on top instead of below. Leverage some of the work
> you did...
OK, just FYI, I had to change bio_has_data() to test bio->bi_vcnt
(rather than bio->bi_io_vec != NULL) because a discard bio has a
non-NULL bio->bi_io_vec (likely points to the bio->bi_inline_vecs but I
didn't check yet).
But I haven't put my finger on _why_ a discard bio has bio->bi_io_vec
(but given my use of DM, bio comes from bio_alloc_bioset, and DM passes
original bio->bi_max_vecs for nr_iovecs).
Anyway, this bio_has_data() change seemed reasonable considering
bio_data() checks bio->bi_vcnt.
next prev parent reply other threads:[~2012-08-20 13:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 7:32 [patch v2 0/6] Add TRIM support for raid linear/0/1/10 Shaohua Li
2012-03-16 7:32 ` [patch v2 1/6] block: makes bio_split support bio without data Shaohua Li
2012-03-16 7:32 ` [patch v2 2/6] blk: dont allow discard request merge temporarily Shaohua Li
2012-03-20 16:21 ` Vivek Goyal
2012-03-21 1:22 ` Shaohua Li
2012-03-21 12:14 ` [patch 1/2]block: handle merged discard request Shaohua Li
2012-03-22 2:32 ` Martin K. Petersen
2012-03-22 2:39 ` Shaohua Li
2012-03-22 2:53 ` Martin K. Petersen
2012-06-20 8:57 ` Christoph Hellwig
2012-06-22 3:46 ` Martin K. Petersen
2012-08-03 2:10 ` Shaohua Li
2012-08-18 3:06 ` Mike Snitzer
2012-08-18 3:47 ` Martin K. Petersen
2012-08-20 13:57 ` Mike Snitzer [this message]
2012-08-20 13:58 ` Christoph Hellwig
2012-08-20 14:12 ` Mike Snitzer
2012-08-20 14:15 ` Christoph Hellwig
2012-03-22 2:18 ` [patch v2 2/6] blk: dont allow discard request merge temporarily Martin K. Petersen
2012-03-22 2:33 ` Shaohua Li
2012-03-22 6:28 ` Christoph Hellwig
2012-03-16 7:32 ` [patch v2 3/6] md: linear supports TRIM Shaohua Li
2012-03-16 7:32 ` [patch v2 4/6] md: raid 0 " Shaohua Li
2012-03-16 7:32 ` [patch v2 5/6] md: raid 1 " Shaohua Li
2012-03-16 7:32 ` [patch v2 6/6] md: raid 10 " Shaohua Li
2012-03-19 19:38 ` [patch v2 0/6] Add TRIM support for raid linear/0/1/10 Holger Kiehl
2012-03-20 1:27 ` Shaohua Li
2012-03-20 9:50 ` Holger Kiehl
2012-03-20 12:09 ` Shaohua Li
2012-03-21 2:08 ` Shaohua Li
2012-03-21 2:24 ` Roberto Spadim
2012-03-21 2:29 ` Mathias Burén
2012-03-21 2:29 ` Mathias Burén
2012-05-08 9:59 ` Patelczyk, Maciej
2012-05-09 2:27 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820135739.GB28570@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
--cc=shli@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).