From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755796Ab2HTRgm (ORCPT ); Mon, 20 Aug 2012 13:36:42 -0400 Received: from mail.free-electrons.com ([88.190.12.23]:52393 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755709Ab2HTRgi convert rfc822-to-8bit (ORCPT ); Mon, 20 Aug 2012 13:36:38 -0400 Date: Mon, 20 Aug 2012 19:36:22 +0200 From: Thomas Petazzoni To: Sebastian Hesselbarth Cc: Linus Walleij , Grant Likely , Rob Herring , Rob Landley , Russell King , Lior Amsalem , Andrew Lunn , Gregory CLEMENT , Ben Dooks , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Warren Subject: Re: [PATCH 04/11] pinctrl: mvebu: add pinctrl driver for Armada 370 Message-ID: <20120820193622.4e539451@skate> In-Reply-To: <50326A60.1070007@gmail.com> References: <1344689809-6223-1-git-send-email-sebastian.hesselbarth@gmail.com> <1344689809-6223-5-git-send-email-sebastian.hesselbarth@gmail.com> <50326A60.1070007@gmail.com> Organization: Free Electrons X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Mon, 20 Aug 2012 18:48:32 +0200, Sebastian Hesselbarth a écrit : > this is really difficult here ;) I thought I could just add PINCTRL_DOVE > to MACH_DOVE inside ARCH_MVEBU, PINCTRL_KIRKWOOD to MACH_KIRKWOOD, aso. > But there is a common MACH_ARMADA_370_XP for both 370 and XP obviously. > > If it is ok for you I will add both PINCTRL_ stubs to the Kconfig and > you work it out if you ever have two distinct MACHs? Or it could remain > selectable in pinctrl/Kconfig but that will then be different with the > other stubs. In order to keep the consistency with other SoC families, maybe we can split the 370 and XP options in two separate MACH_ARMADA_370 and MACH_ARMADA_XP. So, in the ideal world, once all Marvell EBU SoCs are converted to DT+mach-mvebu, we should have: *) arch/arm/Kconfig defines MACH_MVEBU *) arch/arm/mach-mvebu/Kconfig defines MACH_KIRKWOOD, MACH_DOVE, MACH_MX78X00, MACH_ARMADA_370, MACH_ARMADA_XP, MACH_ORION5X Then, an user is free to build a single kernel image that supports all, or a selection of the supported Marvell EBU SoCs. Would that be ok with you? If that's fine with you, then I would prefer if we keep the single MACH_ARMADA_370_XP symbol for now, so that your pinctrl set of patches does not depend on something else. We would do the small Kconfig option refactoring as a follow-up set of patches. Thoughts? Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com