From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755580Ab2HUJcl (ORCPT ); Tue, 21 Aug 2012 05:32:41 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:61413 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753819Ab2HUJci (ORCPT ); Tue, 21 Aug 2012 05:32:38 -0400 Date: Tue, 21 Aug 2012 11:32:31 +0200 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Andi Kleen , Ben Hutchings , Borislav Petkov , Corey Ashford , David Ahern , Feng Tang , Frederic Weisbecker , Jiri Olsa , Mike Galbraith , Namhyung Kim , Namhyung Kim , Namhyung Kim , Paul Mackerras , Pekka Enberg , Peter Zijlstra , Robert Richter , Sedat Dilek , Stephane Eranian , Steven Rostedt , Thomas Gleixner , Ulrich Drepper , arnaldo.melo@gmail.com, Arnaldo Carvalho de Melo Subject: Re: [GIT PULL 00/24] perf/core improvements and fixes Message-ID: <20120821093231.GA12385@gmail.com> References: <1345479985-18669-1-git-send-email-acme@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1345479985-18669-1-git-send-email-acme@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnaldo Carvalho de Melo wrote: > Hi Ingo, > > Please consider pulling, this is on top of my previous pull requests, > > - Arnaldo > > The following changes since commit 0fe7d7e9761ec7e23350b5543ddac470bb3cde1e: > > perf symbols: Add description of JIT interface (2012-08-13 14:55:02 -0300) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo > > for you to fetch changes up to 000078bc3ee69efb1124b8478c7527389a826074: > > perf hists: Rename and move some functions (2012-08-20 09:47:31 -0300) > > ---------------------------------------------------------------- > perf/core improvements and fixes: > > . Fix include order for bison/flex-generated C files, from Ben Hutchings > > . Build fixes and documentation corrections from David Ahern > > . Group parsing support, from Jiri Olsa > > . UI/gtk refactorings and improvements from Namhyung Kim > > . NULL deref fix for perf script, from Namhyung Kim > > . Assorted cleanups from Robert Richter > > . Let O= makes handle relative paths, from Steven Rostedt > > Signed-off-by: Arnaldo Carvalho de Melo > > ---------------------------------------------------------------- > Arnaldo Carvalho de Melo (3): > perf tools: Add missing files to build the python binding > perf evlist: Rename __group method to __set_leader > perf evlist: Introduce evsel list accessors > > Ben Hutchings (1): > perf tools: Fix include order for bison/flex-generated C files > > David Ahern (3): > perf script perl/python: Fix libexec scripts path in Documentation > perf: silence GTK2 probing errors > perf symbols: Fix builds with NO_LIBELF set > > Jiri Olsa (4): > perf tools: Add support to parse event group syntax > perf tools: Add support to update event modifier > perf tools: Enable grouping logic for parsed events > perf test: Add automated tests for event group parsing > > Namhyung Kim (8): > perf script: Fix a NULL pointer dereference > perf ui: Introduce struct ui_helpline > perf ui gtk: Implement helpline_fns > perf ui/gtk: Use helpline API in browser > perf ui gtk: Add perf_gtk__show_helpline() for pr_* > perf ui gtk: Ensure not to call gtk_main_quit() twice > perf hists: Separate out hist print functions > perf hists: Rename and move some functions > > Robert Richter (4): > perf tools: Fix type for evsel->ids and add size check for ids > perf tools: Report number of pmu type of unknown events > perf tools: Rename some variables for better understanding > perf tools: Rename global variable 'events' in util/header.c > > Steven Rostedt (1): > perf tools: Let O= makes handle relative paths > > tools/perf/Documentation/perf-script-perl.txt | 4 +- > tools/perf/Documentation/perf-script-python.txt | 10 +- > tools/perf/Makefile | 20 +- > tools/perf/builtin-record.c | 17 +- > tools/perf/builtin-stat.c | 15 +- > tools/perf/builtin-test.c | 10 +- > tools/perf/builtin-top.c | 18 +- > tools/perf/ui/browsers/hists.c | 4 +- > tools/perf/ui/gtk/browser.c | 5 +- > tools/perf/ui/gtk/gtk.h | 2 + > tools/perf/ui/gtk/helpline.c | 56 ++ > tools/perf/ui/gtk/setup.c | 3 + > tools/perf/ui/gtk/util.c | 5 - > tools/perf/ui/helpline.c | 56 +- > tools/perf/ui/helpline.h | 33 +- > tools/perf/ui/setup.c | 4 + > tools/perf/ui/stdio/hist.c | 653 ++++++++++++++++++++++ > tools/perf/ui/tui/helpline.c | 57 ++ > tools/perf/ui/tui/setup.c | 2 - > tools/perf/util/debug.c | 4 +- > tools/perf/util/debug.h | 8 +- > tools/perf/util/evlist.c | 73 +-- > tools/perf/util/evlist.h | 27 +- > tools/perf/util/evsel.c | 52 +- > tools/perf/util/evsel.h | 20 +- > tools/perf/util/header.c | 97 ++-- > tools/perf/util/header.h | 2 +- > tools/perf/util/hist.c | 677 +---------------------- > tools/perf/util/hist.h | 6 +- > tools/perf/util/parse-events-test.c | 387 ++++++++++--- > tools/perf/util/parse-events.c | 93 +++- > tools/perf/util/parse-events.h | 4 +- > tools/perf/util/parse-events.l | 2 + > tools/perf/util/parse-events.y | 93 +++- > tools/perf/util/python-ext-sources | 2 + > tools/perf/util/python.c | 7 +- > tools/perf/util/symbol-elf.c | 3 + > tools/perf/util/symbol.c | 2 +- > tools/perf/util/top.c | 3 +- > tools/perf/util/trace-event-parse.c | 2 +- > tools/scripts/Makefile.include | 6 +- > 41 files changed, 1560 insertions(+), 984 deletions(-) > create mode 100644 tools/perf/ui/gtk/helpline.c > create mode 100644 tools/perf/ui/stdio/hist.c > create mode 100644 tools/perf/ui/tui/helpline.c Pulled this and the previous two pull requests, thanks a lot Arnaldo! One minor observation, the Makefile tells us: Makefile:496: No libunwind found. Please install libunwind >= 0.99 I guess that should be libunwind-dev[el], right? Plain libunwind is not enough. Thanks, Ingo