From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver
Date: Tue, 21 Aug 2012 14:22:22 +0100 [thread overview]
Message-ID: <20120821132222.GF7995@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120821124243.GG10347@arwen.pp.htv.fi>
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
On Tue, Aug 21, 2012 at 03:42:45PM +0300, Felipe Balbi wrote:
> On Tue, Aug 21, 2012 at 01:41:46PM +0100, Mark Brown wrote:
> > > + regmap_read(smsc->regmap, SMSC_DEV_ID, &ret);
> > > + dev_dbg(&i2c->dev, "SMSC Device ID: %d\n", ret);
> > I'd make these log messages dev_info() or something.
> dev_info() ? It'lll just make boot noisier for no good reason. Which
> user wants to see this during boot up ? That's a debugging feature for
> develop IMHO.
Most of the registers appeared to be chip revision information which is
most definitely useful to tell people about, though possibly with neater
formatting ("why is this batch of boards failing... oh, right"). If
they're fixed device IDs then the driver should instead be verifying
that the registers contain the expected values and bombing out if they
don't. Either way dev_dbg() isn't too helpful.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-21 13:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 10:45 [PATCH 0/4] Add mfd driver for smsc-ece1099 chip Sourav Poddar
2012-08-21 10:45 ` [PATCH 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver Sourav Poddar
2012-08-21 12:41 ` Mark Brown
2012-08-21 12:42 ` Felipe Balbi
2012-08-21 13:22 ` Mark Brown [this message]
2012-08-21 13:27 ` Felipe Balbi
2012-08-21 13:49 ` Mark Brown
2012-08-21 13:52 ` Felipe Balbi
2012-08-21 14:08 ` Mark Brown
2012-08-21 14:09 ` Felipe Balbi
2012-08-21 14:20 ` Mark Brown
2012-08-21 10:45 ` [PATCH 2/4] Input: keypad: Add smsc ece1099 keypad driver Sourav Poddar
2012-08-21 10:45 ` Felipe Balbi
2012-08-21 11:30 ` Poddar, Sourav
2012-08-21 10:46 ` Felipe Balbi
2012-08-21 11:31 ` Poddar, Sourav
2012-08-21 10:45 ` [PATCH 3/4] arm/dts: omap5-evm: Add keypad support Sourav Poddar
2012-08-21 10:47 ` Felipe Balbi
2012-08-21 11:20 ` Poddar, Sourav
2012-08-21 10:45 ` [RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature Sourav Poddar
2012-08-21 10:53 ` Felipe Balbi
2012-08-21 11:47 ` Poddar, Sourav
2012-08-21 12:00 ` Felipe Balbi
2012-08-21 12:20 ` Poddar, Sourav
2012-08-21 12:22 ` Felipe Balbi
2012-08-21 14:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821132222.GF7995@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).