From: Hans Verkuil <hverkuil@xs4all.nl>
To: Volokh Konstantin <volokh84@gmail.com>
Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, volokh@telros.ru
Subject: Re: [PATCH 04/10] staging: media: go7007: Add IDENT for TW2802/2804
Date: Wed, 22 Aug 2012 10:05:18 +0200 [thread overview]
Message-ID: <201208221005.18039.hverkuil@xs4all.nl> (raw)
In-Reply-To: <1345632319-23224-4-git-send-email-volokh84@gmail.com>
On Wed August 22 2012 12:45:13 Volokh Konstantin wrote:
> Signed-off-by: Volokh Konstantin <volokh84@gmail.com>
> ---
> include/media/v4l2-chip-ident.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/media/v4l2-chip-ident.h b/include/media/v4l2-chip-ident.h
> index 7395c81..5395495 100644
> --- a/include/media/v4l2-chip-ident.h
> +++ b/include/media/v4l2-chip-ident.h
> @@ -113,6 +113,10 @@ enum {
> /* module vp27smpx: just ident 2700 */
> V4L2_IDENT_VP27SMPX = 2700,
>
> + /* module wis-tw2804: 2802/2804 */
> + V4L2_IDENT_TW2802 = 2802,
> + V4L2_IDENT_TW2804 = 2804,
> +
> /* module vpx3220: reserved range: 3210-3229 */
> V4L2_IDENT_VPX3214C = 3214,
> V4L2_IDENT_VPX3216B = 3216,
>
There is no need to add this, unless the g/s_register or g_chip_ident ops
are also implemented.
In this case I'd just drop this patch.
Regards,
Hans
next prev parent reply other threads:[~2012-08-22 8:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 10:45 [PATCH 01/10] staging: media: go7007: Some additional code for TW2804 driver functionality Volokh Konstantin
2012-08-22 8:01 ` Hans Verkuil
2012-08-22 10:45 ` [PATCH 02/10] staging: media: go7007: TW2804 driver fix Volokh Konstantin
2012-08-22 10:45 ` [PATCH 03/10] staging: media: go7007: Non main code changing Volokh Konstantin
2012-08-22 10:45 ` [PATCH 04/10] staging: media: go7007: Add IDENT for TW2802/2804 Volokh Konstantin
2012-08-22 8:05 ` Hans Verkuil [this message]
2012-08-22 10:45 ` [PATCH 05/10] staging: media: go7007: Cleanup unused old code Volokh Konstantin
2012-08-22 10:45 ` [PATCH 06/10] staging: media: go7007: tw2804 ADC power control Volokh Konstantin
2012-08-22 10:45 ` [PATCH 07/10] staging: media: go7007: README TODO Volokh Konstantin
2012-08-22 10:45 ` [PATCH 08/10] staging: media: go7007: some additional functionality for sub Volokh Konstantin
2012-08-22 10:45 ` [PATCH 09/10] staging: media: go7007: Adlink_MPG24 board initialization fix Volokh Konstantin
2012-08-22 10:45 ` [PATCH 10/10] staging: media: go7007: some i2c initialization Volokh Konstantin
2012-09-10 8:48 ` [PATCH 01/10] staging: media: go7007: Some additional code for TW2804 driver functionality Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208221005.18039.hverkuil@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=volokh84@gmail.com \
--cc=volokh@telros.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).