From: "Richard W.M. Jones" <rjones@redhat.com>
To: Hugh Dickins <hughd@google.com>
Cc: Jeff Moyer <jmoyer@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jens Axboe <jaxboe@fusionio.com>,
Torsten Hilbrich <torsten.hilbrich@secunet.com>,
Josh Boyer <jwboyer@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: replace __getblk_slow misfix by grow_dev_page fix
Date: Wed, 22 Aug 2012 12:52:44 +0100 [thread overview]
Message-ID: <20120822115243.GU1448@rhmail.home.annexia.org> (raw)
In-Reply-To: <alpine.LSU.2.00.1208211826270.2488@eggly.anvils>
On Tue, Aug 21, 2012 at 06:33:45PM -0700, Hugh Dickins wrote:
> Jeff,
>
> Your commit 91f68c89d8f3 ("block: fix infinite loop in __getblk_slow"),
> already gone into 3.* stable, is not good. Could you and your testers
> please give this alternative a try - I think it should work, and have
> started it on a few days' memory load on 3.5, but not tried your case.
I have tested your patch and it does NOT fix the problem in
http://bugzilla.redhat.com/835019
Kernel 3.6.0 + your patch => mount goes into a loop when mounting
a small empty partition. Please do NOT apply this as it will
cause a regression!
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
next prev parent reply other threads:[~2012-08-22 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 1:33 [PATCH] block: replace __getblk_slow misfix by grow_dev_page fix Hugh Dickins
2012-08-22 9:12 ` Richard W.M. Jones
2012-08-22 11:52 ` Richard W.M. Jones [this message]
2012-08-23 4:56 ` Hugh Dickins
2012-08-23 10:20 ` Jens Axboe
2012-08-23 20:40 ` Jeff Moyer
2012-08-23 22:46 ` Hugh Dickins
2012-08-24 13:13 ` Jeff Moyer
2012-08-28 11:14 ` Richard W.M. Jones
2012-08-28 14:35 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822115243.GU1448@rhmail.home.annexia.org \
--to=rjones@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jaxboe@fusionio.com \
--cc=jmoyer@redhat.com \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torsten.hilbrich@secunet.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).