From: Mike Turquette <mturquette@linaro.org>
To: Chao Xie <xiechao.mail@gmail.com>,
haojian.zhuang@gmail.com, viresh.linux@gmail.com,
s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, chao.xie@marvell.com,
arnd@arndb.de
Subject: Re: [PATCH V5 0/5] clk: mmp: add clock framework for mmp
Date: Fri, 24 Aug 2012 17:21:51 -0700 [thread overview]
Message-ID: <20120825002151.18366.99434@nucleus> (raw)
In-Reply-To: <1345431315-8037-1-git-send-email-xiechao.mail@gmail.com>
Quoting Chao Xie (2012-08-19 19:55:10)
> From: Chao Xie <chao.xie@marvell.com>
> arch/arm/mach-mmp/Kconfig | 3 +
> drivers/clk/Makefile | 3 +
> drivers/clk/mmp/Makefile | 9 +
> drivers/clk/mmp/clk-apbc.c | 152 ++++++++++++++
> drivers/clk/mmp/clk-apmu.c | 97 +++++++++
> drivers/clk/mmp/clk-frac.c | 153 ++++++++++++++
> drivers/clk/mmp/clk-mmp2.c | 449 ++++++++++++++++++++++++++++++++++++++++++
> drivers/clk/mmp/clk-pxa168.c | 346 ++++++++++++++++++++++++++++++++
> drivers/clk/mmp/clk-pxa910.c | 320 ++++++++++++++++++++++++++++++
> drivers/clk/mmp/clk.h | 35 ++++
Looks like you are not removing your arch/arm/mach-mmp/clock.c. Is that
intentional?
When I apply your series against v3.6-rc3 I find that compilation breaks
with mmp2_defconfig due to conflicting definitions for the clk api
(clk_enable, clk_set_rate, etc). This is not surprising since your
legacy clock code is neither deleted nor removed from compilation
conditionally by checking for CONFIG_COMMON_CLK.
Did I somehow manage to misapply your patches or should your patches
have removed the arch-specific clock framework as well?
Regards,
Mike
> 10 files changed, 1567 insertions(+), 0 deletions(-)
> create mode 100644 drivers/clk/mmp/Makefile
> create mode 100644 drivers/clk/mmp/clk-apbc.c
> create mode 100644 drivers/clk/mmp/clk-apmu.c
> create mode 100644 drivers/clk/mmp/clk-frac.c
> create mode 100644 drivers/clk/mmp/clk-mmp2.c
> create mode 100644 drivers/clk/mmp/clk-pxa168.c
> create mode 100644 drivers/clk/mmp/clk-pxa910.c
> create mode 100644 drivers/clk/mmp/clk.h
next prev parent reply other threads:[~2012-08-25 0:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 2:55 [PATCH V5 0/5] clk: mmp: add clock framework for mmp Chao Xie
2012-08-20 2:55 ` [PATCH V5 1/5] clk: mmp: add mmp specific clocks Chao Xie
2012-08-20 2:55 ` [PATCH V5 2/5] clk: mmp: add clock definition for pxa168 Chao Xie
2012-08-20 2:55 ` [PATCH V5 3/5] clk: mmp: add clock definition for pxa910 Chao Xie
2012-08-20 2:55 ` [PATCH V5 4/5] clk: mmp: add clock definition for mmp2 Chao Xie
2012-08-20 2:55 ` [PATCH V5 5/5] arm: mmp: make all SOCs use common clock by default Chao Xie
2012-08-20 5:39 ` [PATCH V5 0/5] clk: mmp: add clock framework for mmp Arnd Bergmann
2012-08-25 0:21 ` Mike Turquette [this message]
2012-08-27 1:19 ` Chao Xie
[not found] ` <20120829182639.4450.99900@nucleus>
2012-09-11 5:54 ` Chao Xie
2012-09-11 13:33 ` Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120825002151.18366.99434@nucleus \
--to=mturquette@linaro.org \
--cc=arnd@arndb.de \
--cc=chao.xie@marvell.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=viresh.linux@gmail.com \
--cc=xiechao.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).