From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: dedekind1@gmail.com
Cc: Huang Shijie <shijie8@gmail.com>,
dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs
Date: Wed, 29 Aug 2012 11:51:12 +0300 [thread overview]
Message-ID: <20120829115112.389fc40c@halley> (raw)
In-Reply-To: <1346228165.2848.432.camel@sauron.fi.intel.com>
On Wed, 29 Aug 2012 11:16:05 +0300 Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Sun, 2012-08-26 at 09:06 +0300, Shmulik Ladkani wrote:
> > root 100m@0
> > kernel 100m@100m
> > rootfs 800m@200m (truncated)
> > user 0@1g (truncated)
> > rest 0@1g
>
> Who would benefit from having those 2 0-sized partitions and how? How
> many users/scripts would be confused by this (these 2 ghost partitions
> would be visible in /proc/mtd and sysfs)? How much RAM would we spend
> for creating sysfs files and directories for these ghost partitions
> (note, one sysfs file costs a couple KiB I thing, because 'sizeof
> (struct inode)').
>
> While you suggestion is clever, do we really benefit from this?
Artem, please note this is just a side effect of what I've suggested
(that its, continue parsing after first truncated partition), not a real
use case I'd expect and intentionally wish to support.
I am used to specify partitions explicitly using size@offset (specifying
offset for all parts, even if sometimes adjacent), and sometimes in an
unsorted fashion.
I never defined some partition that got truncated, so the whole
discussion is theoretical to _my_ usecase.
The only benefit of continuing to parse, is that if there _are_ later
partitions which are defined _explicitly_ with an offset, whose location
is _before_ the truncated partition, these would still be parsed and
registered.
Not so important, and would rarely happen, but simplistic and naive.
And reagrding 0 sized partitions, we can always skip these.
Regards,
Shmulik
next prev parent reply other threads:[~2012-08-29 8:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-25 14:26 [PATCH v2] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs Huang Shijie
2012-08-25 9:02 ` Shmulik Ladkani
2012-08-25 9:26 ` Huang Shijie
2012-08-25 9:42 ` Shmulik Ladkani
2012-08-25 11:07 ` Huang Shijie
2012-08-26 6:06 ` Shmulik Ladkani
2012-08-26 6:47 ` Huang Shijie
2012-08-29 8:24 ` Artem Bityutskiy
2012-08-29 8:48 ` Huang Shijie
2012-08-29 8:16 ` Artem Bityutskiy
2012-08-29 8:51 ` Shmulik Ladkani [this message]
2012-08-29 9:10 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120829115112.389fc40c@halley \
--to=shmulik.ladkani@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).