* [PATCH 2/8] ext3: drop lock/unlock super
@ 2012-08-30 14:56 Marco Stornelli
2012-08-30 15:12 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Marco Stornelli @ 2012-08-30 14:56 UTC (permalink / raw)
To: Al Viro
Cc: Jan Kara, Andrew Morton, Andreas Dilger, linux-ext4,
linux-kernel, Linux FS Devel
Removed lock/unlock super.
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
---
fs/ext3/super.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 8c892e9..9b3d498 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -2571,11 +2571,9 @@ out:
static int ext3_unfreeze(struct super_block *sb)
{
if (!(sb->s_flags & MS_RDONLY)) {
- lock_super(sb);
/* Reser the needs_recovery flag before the fs is unlocked. */
EXT3_SET_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER);
ext3_commit_super(sb, EXT3_SB(sb)->s_es, 1);
- unlock_super(sb);
journal_unlock_updates(EXT3_SB(sb)->s_journal);
}
return 0;
@@ -2595,7 +2593,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
#endif
/* Store the original options */
- lock_super(sb);
old_sb_flags = sb->s_flags;
old_opts.s_mount_opt = sbi->s_mount_opt;
old_opts.s_resuid = sbi->s_resuid;
@@ -2701,8 +2698,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
old_opts.s_qf_names[i] != sbi->s_qf_names[i])
kfree(old_opts.s_qf_names[i]);
#endif
- unlock_super(sb);
-
if (enable_quota)
dquot_resume(sb, -1);
return 0;
@@ -2721,7 +2716,6 @@ restore_opts:
sbi->s_qf_names[i] = old_opts.s_qf_names[i];
}
#endif
- unlock_super(sb);
return err;
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/8] ext3: drop lock/unlock super
2012-08-30 14:56 [PATCH 2/8] ext3: drop lock/unlock super Marco Stornelli
@ 2012-08-30 15:12 ` Jan Kara
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kara @ 2012-08-30 15:12 UTC (permalink / raw)
To: Marco Stornelli
Cc: Al Viro, Jan Kara, Andrew Morton, Andreas Dilger, linux-ext4,
linux-kernel, Linux FS Devel
On Thu 30-08-12 16:56:49, Marco Stornelli wrote:
> Removed lock/unlock super.
>
> Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
You can add: Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext3/super.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 8c892e9..9b3d498 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -2571,11 +2571,9 @@ out:
> static int ext3_unfreeze(struct super_block *sb)
> {
> if (!(sb->s_flags & MS_RDONLY)) {
> - lock_super(sb);
> /* Reser the needs_recovery flag before the fs is unlocked. */
> EXT3_SET_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER);
> ext3_commit_super(sb, EXT3_SB(sb)->s_es, 1);
> - unlock_super(sb);
> journal_unlock_updates(EXT3_SB(sb)->s_journal);
> }
> return 0;
> @@ -2595,7 +2593,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
> #endif
>
> /* Store the original options */
> - lock_super(sb);
> old_sb_flags = sb->s_flags;
> old_opts.s_mount_opt = sbi->s_mount_opt;
> old_opts.s_resuid = sbi->s_resuid;
> @@ -2701,8 +2698,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
> old_opts.s_qf_names[i] != sbi->s_qf_names[i])
> kfree(old_opts.s_qf_names[i]);
> #endif
> - unlock_super(sb);
> -
> if (enable_quota)
> dquot_resume(sb, -1);
> return 0;
> @@ -2721,7 +2716,6 @@ restore_opts:
> sbi->s_qf_names[i] = old_opts.s_qf_names[i];
> }
> #endif
> - unlock_super(sb);
> return err;
> }
>
> --
> 1.7.3.4
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/8] ext3: drop lock/unlock super
@ 2012-10-06 10:39 Marco Stornelli
0 siblings, 0 replies; 3+ messages in thread
From: Marco Stornelli @ 2012-10-06 10:39 UTC (permalink / raw)
To: Al Viro
Cc: Jan Kara, Andrew Morton, Andreas Dilger, linux-ext4,
linux-kernel, Linux FS Devel
Removed lock/unlock super.
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
fs/ext3/super.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 17ae5c8..29e7971 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -2578,11 +2578,9 @@ out:
static int ext3_unfreeze(struct super_block *sb)
{
if (!(sb->s_flags & MS_RDONLY)) {
- lock_super(sb);
/* Reser the needs_recovery flag before the fs is unlocked. */
EXT3_SET_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER);
ext3_commit_super(sb, EXT3_SB(sb)->s_es, 1);
- unlock_super(sb);
journal_unlock_updates(EXT3_SB(sb)->s_journal);
}
return 0;
@@ -2602,7 +2600,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
#endif
/* Store the original options */
- lock_super(sb);
old_sb_flags = sb->s_flags;
old_opts.s_mount_opt = sbi->s_mount_opt;
old_opts.s_resuid = sbi->s_resuid;
@@ -2708,8 +2705,6 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data)
old_opts.s_qf_names[i] != sbi->s_qf_names[i])
kfree(old_opts.s_qf_names[i]);
#endif
- unlock_super(sb);
-
if (enable_quota)
dquot_resume(sb, -1);
return 0;
@@ -2728,7 +2723,6 @@ restore_opts:
sbi->s_qf_names[i] = old_opts.s_qf_names[i];
}
#endif
- unlock_super(sb);
return err;
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-06 10:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-30 14:56 [PATCH 2/8] ext3: drop lock/unlock super Marco Stornelli
2012-08-30 15:12 ` Jan Kara
2012-10-06 10:39 Marco Stornelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).