From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753186Ab2H3XC1 (ORCPT ); Thu, 30 Aug 2012 19:02:27 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:46393 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524Ab2H3XCZ (ORCPT ); Thu, 30 Aug 2012 19:02:25 -0400 Date: Thu, 30 Aug 2012 16:02:21 -0700 From: Dmitry Torokhov To: Lee Jones Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, broonie@opensource.wolfsonmicro.com, linux-input@vger.kernel.org Subject: Re: [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual Message-ID: <20120830230221.GD21501@core.coreip.homeip.net> References: <1344527635-6163-1-git-send-email-lee.jones@linaro.org> <1344527635-6163-9-git-send-email-lee.jones@linaro.org> <20120821092328.GC26899@gmail.com> <20120821164244.GA4672@core.coreip.homeip.net> <20120830131202.GG14145@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120830131202.GG14145@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 30, 2012 at 02:12:04PM +0100, Lee Jones wrote: > > Sorry for the delay. Yes, this shoudl be fine, but since it is > > essentially a revert of the original patch it should be pushed in as > > such. > > How's this? > Excellent. > Author: Lee Jones > Date: Thu Aug 30 14:08:19 2012 +0100 > > Revert "input: ab8500-ponkey: Create AB8500 domain IRQ mapping" > > This reverts commit ca3b3faf9bee4dc5df4f10eae2d1e48f7de0a8ad. > > There was a plan to place ab8500_irq_get_virq() calls in each AB8500 > child device prior to requesting an IRQ, but as we're no longer using > Device Tree to collect our IRQ numbers, it's actually better to allow > the core to do this during device registration time. So the IRQ number > we pull from its resource has already been converted to a virtual IRQ. > > CC: Dmitry Torokhov > CC: linux-input@vger.kernel.org > Acked-by: Linus Walleij Acked-by: Dmitry Torokhov > Signed-off-by: Lee Jones > > diff --git a/drivers/input/misc/ab8500-ponkey.c b/drivers/input/misc/ab8500-ponkey.c > index f06231b..84ec691 100644 > --- a/drivers/input/misc/ab8500-ponkey.c > +++ b/drivers/input/misc/ab8500-ponkey.c > @@ -74,8 +74,8 @@ static int __devinit ab8500_ponkey_probe(struct platform_device *pdev) > > ponkey->idev = input; > ponkey->ab8500 = ab8500; > - ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf); > - ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr); > + ponkey->irq_dbf = irq_dbf; > + ponkey->irq_dbr = irq_dbr; > > input->name = "AB8500 POn(PowerOn) Key"; > input->dev.parent = &pdev->dev; -- Dmitry