From: David Miller <davem@davemloft.net>
To: cjren@qca.qualcomm.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
qca-linux-team@qualcomm.com, nic-devel@qualcomm.com,
xiong@qca.qualcomm.com, rodrigue@qca.qualcomm.com
Subject: Re: [PATCH v3] net: add new QCA alx ethernet driver
Date: Fri, 31 Aug 2012 16:20:58 -0400 (EDT) [thread overview]
Message-ID: <20120831.162058.2022883484639611493.davem@davemloft.net> (raw)
In-Reply-To: <1346083963-17610-1-git-send-email-cjren@qca.qualcomm.com>
From: <cjren@qca.qualcomm.com>
Date: Tue, 28 Aug 2012 00:12:43 +0800
> +/*
> + * Definition to enable some features
> + */
> +#undef CONFIG_ALX_MSIX
> +#undef CONFIG_ALX_MSI
> +#undef CONFIG_ALX_MTQ
> +#undef CONFIG_ALX_MRQ
> +#undef CONFIG_ALX_RSS
> +/* #define CONFIG_ALX_MSIX */
> +#define CONFIG_ALX_MSI
> +#define CONFIG_ALX_MTQ
> +#define CONFIG_ALX_MRQ
> +#ifdef CONFIG_ALX_MRQ
> +#define CONFIG_ALX_RSS
> +#endif
> +
Get rid of all of these. You may never use private feature control macros
in the CONFIG_* namespace, those are for the Kconfig system only.
Local controls of this nature are only appropriate for a driver amidst
development, and not a final version that should be included in the
upstream kernel tree.
You must remove all of these CPP macros, and all code that is currently
protected by the ones which are off.
Just so that your expectations are set appropriately, I anticipate
that there will be at least 5 more rounds of review for things of this
nature before we can even remotely consider adding this driver to the
tree. This driver is very poorly written and is far away from meeting
our standards for incusion.
next prev parent reply other threads:[~2012-08-31 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 16:12 [PATCH v3] net: add new QCA alx ethernet driver cjren
2012-08-31 20:20 ` David Miller [this message]
2012-08-31 22:24 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120831.162058.2022883484639611493.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cjren@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic-devel@qualcomm.com \
--cc=qca-linux-team@qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
--cc=xiong@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).