From: Paul Mundt <lethal@linux-sh.org>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Can not get output of command line on SH
Date: Mon, 3 Sep 2012 13:24:43 +0900 [thread overview]
Message-ID: <20120903042442.GE20229@linux-sh.org> (raw)
In-Reply-To: <CABMQnVKDWN6xftShR_Xt6Odc-jPMSKnU+fqDY+v0tofaM=PTJg@mail.gmail.com>
On Mon, Sep 03, 2012 at 11:56:59AM +0900, Nobuhiro Iwamatsu wrote:
> On Fri, Aug 31, 2012 at 10:10 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> > Smells like broken TIF_NOTIFY_RESUME hookup on sh... Arrrgh. Looks like
> > while it is in the relevant masks *and* checked in do_notify_resume() both
> > on 32bit and 64bit variants since commit ab99c733ae73cce31f2a2434f7099564e5a73d95
> > Author: Paul Mundt <lethal@linux-sh.org>
> > Date: Wed Jul 30 19:55:30 2008 +0900
> >
> > sh: Make syscall tracer use tracehook notifiers, add TIF_NOTIFY_RESUME.
> >
> > they are actually *not* reached without simulataneous SIGPENDING, since the
> > actual glue in the callers had not been updated back then and still checks
> > for _TIF_SIGPENDING alone when deciding whether to hit do_notify_resume()
> > or not. Looks like the following ought to fix that:
>
> Thanks for your reply and explanation.
> I confirmed that revise this problem with your patch.
>
> >
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> Tested-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>
I'll queue it up, thanks!
prev parent reply other threads:[~2012-09-03 4:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 7:32 Can not get output of command line on SH Nobuhiro Iwamatsu
2012-08-31 13:10 ` Al Viro
2012-09-03 2:56 ` Nobuhiro Iwamatsu
2012-09-03 4:24 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903042442.GE20229@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).