linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin McKinney <klmckinney1@gmail.com>
To: Wei Yongjun <weiyj.lk@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, yongjun_wei@trendmicro.com.cn,
	linux-kernel@vger.kernel.org,
	Dan Carpenter <dan.carpenter@oracle.com>,
	klmckinney1@gmail.com
Subject: Re: [PATCH] Staging: bcm: fix possible memory leak in bcm_char_ioctl()
Date: Mon, 3 Sep 2012 21:19:10 -0400	[thread overview]
Message-ID: <20120904011909.GA4010@gmail.com> (raw)
In-Reply-To: <CAPgLHd9HKqsyBydFpCHpcWmY4n2b_2kmZYKPsGfHFKNkiQJLAg@mail.gmail.com>

On Mon, Sep 03, 2012 at 06:02:23PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> psFwInfo has been allocated in this function and should be
> freed before leaving from the error handling cases.
> 
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  drivers/staging/bcm/Bcmchar.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
> index cf411d1..3d02c2e 100644
> --- a/drivers/staging/bcm/Bcmchar.c
> +++ b/drivers/staging/bcm/Bcmchar.c

Acked-by: Kevin McKinney <klmckinney1@gmail.com>

      reply	other threads:[~2012-09-04  1:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03 10:02 Wei Yongjun
2012-09-04  1:19 ` Kevin McKinney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120904011909.GA4010@gmail.com \
    --to=klmckinney1@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=weiyj.lk@gmail.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    --subject='Re: [PATCH] Staging: bcm: fix possible memory leak in bcm_char_ioctl()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).