From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756557Ab2IDJJA (ORCPT ); Tue, 4 Sep 2012 05:09:00 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:46060 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752722Ab2IDJI7 (ORCPT ); Tue, 4 Sep 2012 05:08:59 -0400 Date: Tue, 4 Sep 2012 10:08:54 +0100 From: Lee Jones To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de Subject: Re: [PATCH] ARM: ux500: Provide SMSC911x fixed-regulator when not booting DT Message-ID: <20120904090846.GA6091@gmail.com> References: <1345809612-30992-1-git-send-email-lee.jones@linaro.org> <20120903133333.GE31163@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 04, 2012 at 10:53:32AM +0200, Linus Walleij wrote: > On Mon, Sep 3, 2012 at 3:33 PM, Lee Jones wrote: > > > Author: Lee Jones > > Date: Fri Aug 24 12:40:58 2012 +0100 > > > > ARM: ux500: Provide SMSC911x fixed-regulator when not booting DT > > > > The SMSC911x Ethernet chip requires a fixed-regulator in order to > > function correctly. We have previously provided a means to obtain > > this during a Device Tree boot, however nothing has been put into > > place when booting with a non-DT kernel. This patch aims to change > > that. > > > > Signed-off-by: Lee Jones > > You forgot to add select REGULATOR_FIXED_VOLTAGE to > the MOP500 Kconfig entry, but I added it when applying. I didn't forget. I intentionally left it out because it's unconditionally set in the defconfig. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog