From: Andrew Morton <akpm@linux-foundation.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] kernel/sys.c: call disable_nonboot_cpus in kernel_restart
Date: Tue, 4 Sep 2012 15:36:24 -0700 [thread overview]
Message-ID: <20120904153624.d4aaed4e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1346682298-13958-1-git-send-email-shawn.guo@linaro.org>
On Mon, 3 Sep 2012 22:24:58 +0800
Shawn Guo <shawn.guo@linaro.org> wrote:
> Like kernel_power_off calls disable_nonboot_cpus, we may want to have
> kernel_restart call disable_nonboot_cpus as well. Doing so can help
> the machines that require boot cpu be the last alive cpu during reboot
> to survive with kernel restart.
That does sound logical. But the changelog is very vague and fluffy.
Does this patch actually fix any known problem on any known machine?
> ...
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -368,6 +368,7 @@ EXPORT_SYMBOL(unregister_reboot_notifier);
> void kernel_restart(char *cmd)
> {
> kernel_restart_prepare(cmd);
> + disable_nonboot_cpus();
> if (!cmd)
> printk(KERN_EMERG "Restarting system.\n");
> else
next prev parent reply other threads:[~2012-09-04 22:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 14:24 [PATCH] kernel/sys.c: call disable_nonboot_cpus in kernel_restart Shawn Guo
2012-09-04 22:36 ` Andrew Morton [this message]
2012-09-04 23:42 ` Stephen Boyd
2012-09-05 0:51 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904153624.d4aaed4e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).