linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Jean Delvare <khali@linux-fr.org>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH 1/2] hwmon/lm70: Allow 4wire SPI bus with LM70
Date: Tue, 4 Sep 2012 09:28:12 -0700	[thread overview]
Message-ID: <20120904162812.GB16877@roeck-us.net> (raw)
In-Reply-To: <201209040840.q848eiPg028975@localhost.localdomain>

On Tue, Sep 04, 2012 at 10:40:44AM +0200, Christophe Leroy wrote:
> Removing the 3wire limitation on LM70 as the component also allows
> operation on 4wire SPI bus
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> 
Applied to -next.

Thanks,
Guenter

> diff -u linux-3.5-vanilla/drivers/hwmon/lm70.c linux-3.5/drivers/hwmon/lm70.c
> --- linux-3.5-vanilla/drivers/hwmon/lm70.c	2012-07-21 22:58:29.000000000 +0200
> +++ linux-3.5/drivers/hwmon/lm70.c	2012-08-25 00:35:40.000000000 +0200
> @@ -143,10 +143,6 @@
>  	if (spi->mode & (SPI_CPOL | SPI_CPHA))
>  		return -EINVAL;
>  
> -	/* 3-wire link (shared SI/SO) for LM70 */
> -	if (chip == LM70_CHIP_LM70 && !(spi->mode & SPI_3WIRE))
> -		return -EINVAL;
> -
>  	/* NOTE:  we assume 8-bit words, and convert to 16 bits manually */
>  
>  	p_lm70 = kzalloc(sizeof *p_lm70, GFP_KERNEL);
> diff -u linux-3.5-vanilla/Documentation/hwmon/lm70 linux-3.5/Documentation/hwmon/lm70
> --- linux-3.5-vanilla/Documentation/hwmon/lm70	2012-07-21 22:58:29.000000000 +0200
> +++ linux-3.5/Documentation/hwmon/lm70	2012-08-25 00:37:15.000000000 +0200
> @@ -31,9 +31,8 @@
>  with a "SPI master controller driver", see drivers/spi/spi_lm70llp.c
>  and its associated documentation.
>  
> -The TMP121/TMP123 are very similar; main differences are 4 wire SPI inter-
> -face (read only) and 13-bit temperature data (0.0625 degrees celsius reso-
> -lution).
> +The TMP121/TMP123 are very similar; main difference is 13-bit temperature
> +data (0.0625 degrees celsius resolution).
>  
>  Thanks to
>  ---------
> 

      reply	other threads:[~2012-09-04 16:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-04  8:40 Christophe Leroy
2012-09-04 16:28 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120904162812.GB16877@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=christophe.leroy@c-s.fr \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --subject='Re: [PATCH 1/2] hwmon/lm70: Allow 4wire SPI bus with LM70' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).