archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <>
To: Toshiaki Yamane <>
Subject: Re: [PATCH 1/2] staging/rts_pstor: Use pr_ printks in rtsx.c
Date: Tue, 4 Sep 2012 12:25:59 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Aug 29, 2012 at 10:29:26AM +0900, Toshiaki Yamane wrote:
> fixed some checkpatch warnings.
> -WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
> -WARNING: Prefer pr_err(... to printk(KERN_ERR, ...

No, please use dev_info() and dev_err() instead wherever possible.


greg k-h

  parent reply	other threads:[~2012-09-04 19:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-29  1:29 [PATCH 1/2] staging/rts_pstor: Use pr_ printks in rtsx.c Toshiaki Yamane
2012-08-29  1:30 ` [PATCH 2/2] staging/rts_pstor: Use pr_ printks in debug.h Toshiaki Yamane
2012-09-04 19:26   ` Greg Kroah-Hartman
2012-09-04 19:25 ` Greg Kroah-Hartman [this message]
2012-09-16  7:26 ` [PATCH] staging/rts_pstor: Use pr_ or dev_ printks in rtsx.c Toshiaki Yamane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).