linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, rdunlap@xenotime.net,
	arve@android.com, kernel-team@android.com,
	john.stultz@linaro.org
Subject: Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ
Date: Tue, 4 Sep 2012 23:01:17 +0100	[thread overview]
Message-ID: <20120904230117.5a44eb89@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <5046783D.4020702@linaro.org>

> which brings us to the "reset_fn()" function - in my opinion it offers
> significant advantages and should be kept in the design.  What I'm not
> so clear about is on the implementation.  Should it be kept as part of a
> platform data or be implemented as a notifier as suggested by Alan.  I
> am looking for guidance here and suggestions are encouraged.

Not sure reset_fn is the best name but it'll do for me. As for things like
notifiers, thats extra complexity. *When* someone needs it then they can
add it. We don't need to add extra complexity now.


  reply	other threads:[~2012-09-04 21:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-30 22:30 [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ mathieu.poirier
2012-08-30 23:01 ` Dmitry Torokhov
2012-08-31 21:52   ` Mathieu Poirier
2012-08-31 22:02     ` Alan Cox
2012-08-31 22:41       ` Dmitry Torokhov
2012-08-31 22:57         ` Mathieu Poirier
2012-08-31 23:22           ` Dmitry Torokhov
2012-09-04 21:53             ` Mathieu Poirier
2012-09-04 22:01               ` Alan Cox [this message]
2012-08-31 22:51       ` Mathieu Poirier
2012-09-01 19:18     ` Colin Cross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120904230117.5a44eb89@pyramind.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=arve@android.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=john.stultz@linaro.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).