From: Josh Triplett <josh@joshtriplett.org>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Len Brown <lenb@kernel.org>,
Matt Fleming <matt.fleming@intel.com>,
Olof Johansson <olof@lixom.net>, Matthew Garrett <mjg@redhat.com>,
David Howells <dhowells@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Pawel Moll <pawel.moll@arm.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCHv2 0/4] Fix ACPI BGRT support for images located in EFI boot services memory
Date: Tue, 4 Sep 2012 16:28:44 -0700 [thread overview]
Message-ID: <20120904232843.GA11855@jtriplet-mobl1> (raw)
In-Reply-To: <cover.1346792566.git.josh@joshtriplett.org>
On Tue, Sep 04, 2012 at 02:21:19PM -0700, Josh Triplett wrote:
> v2: Made the new internal function efi_unmap_memmap static. Incorporated
> feedback from H. Peter Anvin and Matt Fleming: added stubs for
> x86-specific EFI functions called from init/main.c to eliminate the
> corresponding ifdefs in start_kernel; deferred
> efi_free_boot_services even later, to just before free_initmem.
Argh, looks like I missed something important in testing: a WARN from
check_early_ioremap_leak. Looks like moving the reclamation of the EFI
memory map that late makes check_early_ioremap_leak figure that it won't
get reclaimed at all.
As far as I can tell, ioremap won't work that early; EFI really does
need to use early_ioremap. Since at the moment we don't seem to have
any other drivers that need to access boot services memory, any
objection to moving efi_free_boot_services back to just after ACPI?
- Josh Triplett
prev parent reply other threads:[~2012-09-04 23:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 21:21 [PATCHv2 0/4] Fix ACPI BGRT support for images located in EFI boot services memory Josh Triplett
2012-09-04 21:23 ` [PATCHv2 1/4] efi: Add a stub for efi_enter_virtual_mode on non-x86 Josh Triplett
2012-09-04 21:23 ` [PATCHv2 2/4] efi: Defer freeing boot services memory until freeing __init memory Josh Triplett
2012-09-04 21:24 ` [PATCHv2 3/4] efi: Add a function to look up existing IO memory mappings Josh Triplett
2012-09-04 21:24 ` [PATCHv2 4/4] efi: Fix the ACPI BGRT driver for images located in EFI boot services memory Josh Triplett
2012-09-04 23:28 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904232843.GA11855@jtriplet-mobl1 \
--to=josh@joshtriplett.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=mjg@redhat.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).