* [PATCH 1/1] Drivers: hv: kvp: Copy the address family information
@ 2012-09-04 22:20 K. Y. Srinivasan
2012-09-04 22:56 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: K. Y. Srinivasan @ 2012-09-04 22:20 UTC (permalink / raw)
To: gregkh, linux-kernel, devel, olaf, apw, ben; +Cc: K. Y. Srinivasan
Copy the address family information.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/hv/hv_kvp.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/hv/hv_kvp.c b/drivers/hv/hv_kvp.c
index d906050..ed50e9e 100644
--- a/drivers/hv/hv_kvp.c
+++ b/drivers/hv/hv_kvp.c
@@ -256,6 +256,8 @@ static int process_ob_ipinfo(void *in_msg, void *out_msg, int op)
out->kvp_ip_val.dhcp_enabled =
in->body.kvp_ip_val.dhcp_enabled;
+ out->kvp_ip_val.addr_family =
+ in->body.kvp_ip_val.addr_family;
}
return 0;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Drivers: hv: kvp: Copy the address family information
2012-09-04 22:20 [PATCH 1/1] Drivers: hv: kvp: Copy the address family information K. Y. Srinivasan
@ 2012-09-04 22:56 ` Greg KH
2012-09-04 23:36 ` KY Srinivasan
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2012-09-04 22:56 UTC (permalink / raw)
To: K. Y. Srinivasan; +Cc: linux-kernel, devel, olaf, apw, ben
On Tue, Sep 04, 2012 at 03:20:19PM -0700, K. Y. Srinivasan wrote:
> Copy the address family information.
Why?
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/1] Drivers: hv: kvp: Copy the address family information
2012-09-04 22:56 ` Greg KH
@ 2012-09-04 23:36 ` KY Srinivasan
2012-09-05 0:02 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: KY Srinivasan @ 2012-09-04 23:36 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, devel, olaf, apw, ben
> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Tuesday, September 04, 2012 6:57 PM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; ben@decadent.org.uk
> Subject: Re: [PATCH 1/1] Drivers: hv: kvp: Copy the address family information
>
> On Tue, Sep 04, 2012 at 03:20:19PM -0700, K. Y. Srinivasan wrote:
> > Copy the address family information.
>
> Why?
This is part of the IP injection protocol in that the host expects this field to reflect what addresses
(address families) are currently bound to the interface. The KVP daemon is currently collecting this
Information and sending it to the kernel component. I had overlooked copying this and sending it
back to the host. This patch addresses this issue.
Regards,
K. Y
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] Drivers: hv: kvp: Copy the address family information
2012-09-04 23:36 ` KY Srinivasan
@ 2012-09-05 0:02 ` Greg KH
2012-09-05 0:29 ` KY Srinivasan
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2012-09-05 0:02 UTC (permalink / raw)
To: KY Srinivasan; +Cc: apw, devel, olaf, ben, linux-kernel
On Tue, Sep 04, 2012 at 11:36:30PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Tuesday, September 04, 2012 6:57 PM
> > To: KY Srinivasan
> > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> > apw@canonical.com; ben@decadent.org.uk
> > Subject: Re: [PATCH 1/1] Drivers: hv: kvp: Copy the address family information
> >
> > On Tue, Sep 04, 2012 at 03:20:19PM -0700, K. Y. Srinivasan wrote:
> > > Copy the address family information.
> >
> > Why?
>
> This is part of the IP injection protocol in that the host expects this field to reflect what addresses
> (address families) are currently bound to the interface. The KVP daemon is currently collecting this
> Information and sending it to the kernel component. I had overlooked copying this and sending it
> back to the host. This patch addresses this issue.
That's nice and descriptive, any reason you didn't put it in the patch
changelog section the first time?
Please redo this...
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 1/1] Drivers: hv: kvp: Copy the address family information
2012-09-05 0:02 ` Greg KH
@ 2012-09-05 0:29 ` KY Srinivasan
0 siblings, 0 replies; 6+ messages in thread
From: KY Srinivasan @ 2012-09-05 0:29 UTC (permalink / raw)
To: Greg KH; +Cc: apw, devel, olaf, ben, linux-kernel
> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Tuesday, September 04, 2012 8:03 PM
> To: KY Srinivasan
> Cc: apw@canonical.com; devel@linuxdriverproject.org; olaf@aepfle.de;
> ben@decadent.org.uk; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/1] Drivers: hv: kvp: Copy the address family information
>
> On Tue, Sep 04, 2012 at 11:36:30PM +0000, KY Srinivasan wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > > Sent: Tuesday, September 04, 2012 6:57 PM
> > > To: KY Srinivasan
> > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> olaf@aepfle.de;
> > > apw@canonical.com; ben@decadent.org.uk
> > > Subject: Re: [PATCH 1/1] Drivers: hv: kvp: Copy the address family
> information
> > >
> > > On Tue, Sep 04, 2012 at 03:20:19PM -0700, K. Y. Srinivasan wrote:
> > > > Copy the address family information.
> > >
> > > Why?
> >
> > This is part of the IP injection protocol in that the host expects this field to
> reflect what addresses
> > (address families) are currently bound to the interface. The KVP daemon is
> currently collecting this
> > Information and sending it to the kernel component. I had overlooked copying
> this and sending it
> > back to the host. This patch addresses this issue.
>
> That's nice and descriptive, any reason you didn't put it in the patch
> changelog section the first time?
>
> Please redo this...
Will do.
Regards,
K. Y
>
> greg k-h
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] Drivers: hv: kvp: Copy the address family information
@ 2012-09-05 0:54 K. Y. Srinivasan
0 siblings, 0 replies; 6+ messages in thread
From: K. Y. Srinivasan @ 2012-09-05 0:54 UTC (permalink / raw)
To: gregkh, linux-kernel, devel, olaf, apw, ben; +Cc: K. Y. Srinivasan
This is part of the IP injection protocol in that the host expects this field
to reflect what addresses (address families) are currently bound to the
interface. The KVP daemon is currently collecting this information and sending
it to the kernel component. I had overlooked copying this and sending it
back to the host. This patch addresses this issue.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/hv/hv_kvp.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/hv/hv_kvp.c b/drivers/hv/hv_kvp.c
index d906050..ed50e9e 100644
--- a/drivers/hv/hv_kvp.c
+++ b/drivers/hv/hv_kvp.c
@@ -256,6 +256,8 @@ static int process_ob_ipinfo(void *in_msg, void *out_msg, int op)
out->kvp_ip_val.dhcp_enabled =
in->body.kvp_ip_val.dhcp_enabled;
+ out->kvp_ip_val.addr_family =
+ in->body.kvp_ip_val.addr_family;
}
return 0;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-05 0:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-04 22:20 [PATCH 1/1] Drivers: hv: kvp: Copy the address family information K. Y. Srinivasan
2012-09-04 22:56 ` Greg KH
2012-09-04 23:36 ` KY Srinivasan
2012-09-05 0:02 ` Greg KH
2012-09-05 0:29 ` KY Srinivasan
2012-09-05 0:54 K. Y. Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).