From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757946Ab2IEAEZ (ORCPT ); Tue, 4 Sep 2012 20:04:25 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:33704 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751980Ab2IEAEX (ORCPT ); Tue, 4 Sep 2012 20:04:23 -0400 Date: Tue, 4 Sep 2012 17:04:19 -0700 From: Greg KH To: KY Srinivasan Cc: "olaf@aepfle.de" , "thozza@redhat.com" , "linux-kernel@vger.kernel.org" , "dcbw@redhat.com" , "apw@canonical.com" , "devel@linuxdriverproject.org" , "ben@decadent.org.uk" Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp state Message-ID: <20120905000419.GC31997@kroah.com> References: <1346795156-25614-1-git-send-email-kys@microsoft.com> <1346795202-25655-1-git-send-email-kys@microsoft.com> <1346795202-25655-5-git-send-email-kys@microsoft.com> <20120904225917.GB3725@kroah.com> <426367E2313C2449837CD2DE46E7EAF9309DFFA2@SN2PRD0310MB382.namprd03.prod.outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <426367E2313C2449837CD2DE46E7EAF9309DFFA2@SN2PRD0310MB382.namprd03.prod.outlook.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 04, 2012 at 11:39:12PM +0000, KY Srinivasan wrote: > > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Tuesday, September 04, 2012 6:59 PM > > To: KY Srinivasan > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de; > > apw@canonical.com; ben@decadent.org.uk; thozza@redhat.com; > > dcbw@redhat.com > > Subject: Re: [PATCH V4 05/10] Tools: hv: Add an example script to retrieve dhcp > > state > > > > On Tue, Sep 04, 2012 at 02:46:37PM -0700, K. Y. Srinivasan wrote: > > > To keep the KVP daemon code free of distro specific details, we invoke an > > > external script to retrieve the DHCP state. This is an example script that > > > was used to test the KVP code. This script has to be implemented in a Distro > > > specific fashion. For instance on distros that ship with Network Manager > > enabled, > > > this script can be based on NM APIs. > > > > > > Signed-off-by: K. Y. Srinivasan > > > Reviewed-by: Haiyang Zhang > > > --- > > > tools/hv/hv_get_dhcp_info.sh | 25 +++++++++++++++++++++++++ > > > 1 files changed, 25 insertions(+), 0 deletions(-) > > > create mode 100755 tools/hv/hv_get_dhcp_info.sh > > > > > > diff --git a/tools/hv/hv_get_dhcp_info.sh b/tools/hv/hv_get_dhcp_info.sh > > > new file mode 100755 > > > index 0000000..3de4587 > > > --- /dev/null > > > +++ b/tools/hv/hv_get_dhcp_info.sh > > > @@ -0,0 +1,25 @@ > > > +#!/bin/bash > > > + > > > +# This example script retrieves the DHCP state of a given interface. > > > +# In the interest of keeping the KVP daemon code free of distro specific > > > +# information; the kvp daemon code invokes this external script to gather > > > +# DHCP setting for the specific interface. > > > +# > > > +# Input: Name of the interface > > > +# > > > +# Output: The script prints the string "Enabled" to stdout to indicate > > > +# that DHCP is enabled on the interface. > > > > What happens if DHCP is not enabled on the interface? Shouldn't that > > also return something other than "success"? > > The script is expected to write "Enabled" to stdout to indicate if DHCP is enabled; if this > is not the case, implicitly we assume DHCP is not enabled (since this is a binary state). It's not really "binary" given that you are expecting "Enabled" or nothing, right? "Disabled" would make a bit more sense perhaps? Having a script return "nothing at all" to show the failure of a state doesn't seem the wisest thing, does it? thanks, greg k-h