From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: ppcdev <linuxppc-dev@lists.ozlabs.org>,
lkml <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
peterz@infradead.org, michael@ellerman.id.au,
Ingo Molnar <mingo@elte.hu>,
oleg@redhat.com
Subject: Re: [PATCH v5 3/3] powerpc: Uprobes port to powerpc
Date: Wed, 5 Sep 2012 11:15:00 +0530 [thread overview]
Message-ID: <20120905054459.GB12521@in.ibm.com> (raw)
In-Reply-To: <1346822819.2257.49.camel@pasglop>
On Wed, Sep 05, 2012 at 03:26:59PM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2012-08-24 at 13:01 +0530, Ananth N Mavinakayanahalli wrote:
> > From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> >
> > This is the port of uprobes to powerpc. Usage is similar to x86.
>
> Guys, can you do a minimum of build testing ?
>
> This one breaks due to uprobe_get_swbp_addr() being defined in both
> asm and include/linux when CONFIG_UPROBE isn't set. You don't need
> to define it at all in fact, the generic code takes care of both the
> declaration for CONFIG_UPROBE and the empty inline for !CONFIG_UPROBE.
>
> I'm fixing that one up myself but please, please, get yourself a test
> build script or something to make sure you don't at least break the
> build when the stuff you're adding isn't enabled (among others).
Sorry Ben. That was an oversight. Won't happen again.
Regards,
Ananth
prev parent reply other threads:[~2012-09-05 5:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 7:26 [PATCH 1/3] powerpc: Consolidate *probe definitions Ananth N Mavinakayanahalli
2012-08-24 7:27 ` [PATCH 2/3] powerpc: Add trap_nr to thread_struct Ananth N Mavinakayanahalli
2012-08-24 7:31 ` [PATCH v5 3/3] powerpc: Uprobes port to powerpc Ananth N Mavinakayanahalli
2012-09-05 5:26 ` Benjamin Herrenschmidt
2012-09-05 5:45 ` Ananth N Mavinakayanahalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905054459.GB12521@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).