From: Tzafrir Cohen <tzafrir.cohen@xorcom.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Linux Kbuild <linux-kbuild@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] builddeb: remove unneeded explicit Architecture
Date: Wed, 5 Sep 2012 16:05:28 +0300 [thread overview]
Message-ID: <20120905130528.GI18204@xorcom.com> (raw)
In-Reply-To: <5040C112.70501@suse.cz>
Hi,
Thanks for your reply,
On Fri, Aug 31, 2012 at 03:50:10PM +0200, Michal Marek wrote:
> Adding Max to CC.
>
> On 14.8.2012 12:44, Tzafrir Cohen wrote:
> > Architecture was set explicitly in debian/control for one of the three
> > packages (linux-libc-dev) but not for the other two. When cross-building
> > it gives me an error:
> >
> > dpkg-gencontrol: error: current host architecture 'armhf' does not
> > appear in package's architecture list (amd64)
> >
> > Also note that if used, dpkg --print-architecture should have been
> > replaced with dpkg-architecture.
> >
> > Signed-off-by: Tzafrir Cohen <tzafrir.cohen@xorcom.com>
> > ---
> > scripts/package/builddeb | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> > index acb8650..d9c71a6 100644
> > --- a/scripts/package/builddeb
> > +++ b/scripts/package/builddeb
> > @@ -252,13 +252,12 @@ mkdir -p "$destdir"
> > (cd $objtree; tar -c -f - -T "$objtree/debian/hdrobjfiles") | (cd $destdir; tar -xf -)
> > ln -sf "/usr/src/linux-headers-$version" "$kernel_headers_dir/lib/modules/$version/build"
> > rm -f "$objtree/debian/hdrsrcfiles" "$objtree/debian/hdrobjfiles"
> > -arch=$(dpkg --print-architecture)
> >
> > cat <<EOF >> debian/control
> >
> > Package: $kernel_headers_packagename
> > Provides: linux-headers, linux-headers-2.6
> > -Architecture: $arch
> > +Architecture: any
> > Description: Linux kernel headers for $KERNELRELEASE on $arch
> > This package provides kernel header files for $KERNELRELEASE on $arch
> > .
>
> As the package contains files from arch/$SRCARCH/include, I doubt that
> this is a valid change.
But you optionally force the Architecture later on in build_package.
"Arhcitecture: any" in the source package states that the binary package
will be the one stated by the build system.
--
Tzafrir Cohen
icq#16849755 jabber:tzafrir.cohen@xorcom.com
+972-50-7952406 mailto:tzafrir.cohen@xorcom.com
http://www.xorcom.com iax:guest@local.xorcom.com/tzafrir
next prev parent reply other threads:[~2012-09-05 13:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 10:44 [PATCH] builddeb: remove unneeded explicit Architecture Tzafrir Cohen
2012-08-31 13:50 ` Michal Marek
2012-09-05 13:05 ` Tzafrir Cohen [this message]
2012-09-05 13:26 ` Michal Marek
2012-09-05 15:14 ` maximilian attems
2012-09-05 16:40 ` Tzafrir Cohen
2012-09-05 20:26 ` maximilian attems
2012-09-06 14:00 ` maximilian attems
2012-09-06 14:04 ` maximilian attems
2012-09-06 16:21 ` Tzafrir Cohen
2012-09-07 0:02 ` maximilian attems
2012-09-09 11:54 ` Tzafrir Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905130528.GI18204@xorcom.com \
--to=tzafrir.cohen@xorcom.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).