archive mirror
 help / color / mirror / Atom feed
From: Thomas Renninger <>
To: "Rafael J. Wysocki" <>
Cc: Andre Przywara <>,
	Matthew Garret <>,,,,
	Andreas Herrmann <>
Subject: Re: [PATCH 0/8 v2] acpi-cpufreq: Move modern AMD cpufreq support to acpi-cpufreq
Date: Wed, 5 Sep 2012 16:25:41 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wednesday, September 05, 2012 03:46:22 PM Rafael J. Wysocki wrote:
> On Tuesday, September 04, 2012, Andre Przywara wrote:
> > Hi,
> > 
> > now the second, revised version of the patch set. I now tested loading
> > both drivers after each other in several combinations, after two bug
> > fixes this now works as expected.
> > I added a patch to move messages from powernow-k8 after the initialization
> > phase, so it remains silent if driver loading fails.
> > 
> > I also rearranged the patches so that the powernow-k8 feature removal patch is
> > now the last one and is somewhat optional. I still prefer to have it in,
> > but it can be dropped if needed. Then powernow-k8 will still support modern
> > AMD CPUs, but will emit a warning message.
> > 
> > Regards,
> > Andre
> > 
> > Changes from v1:
> > * added hints to Kconfig about CPU support
> > * merge documentation from separate patch into the feature patch
> > * add deprecation warning
> > * prefix acpi-cpufreq warning messages with module name
> > * bugfix: avoid boost init it driver registration failed
> > * bugfix: fix module redirect request call (was not reached before)
> I have applied the whole series to the linux-next branch of the linux-pm.git
> tree, but I'm quite unsure about [7/8].  Is it really necessary?  I mean, since
> we want users to switch to a different driver anyway, which already has a knob
> providing the functionality in question, what's the point really?

Afaik this was mostly for compiler people or other developers doing
benchmarks to be able to avoid fluctating numbers caused by turbo/boost

I don't know whether it's used by any userspace tool. If, it would certainly
be an AMD specific tool for developers. If you (AMD) know a userspace tool
out there it may make sense to keep it the one or other kernel round,
otherwise I guess it can simply be deleted.

I will add the functionality (to enable/disable turbo/boost mode)
to cpupower userspace tool as soon as this is in.
Shouldn't be much more than a -t option and a
one liner to read out or set another cpufreq sysfs file.


  reply	other threads:[~2012-09-05 14:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-04  8:28 [PATCH 0/8 v2] acpi-cpufreq: Move modern AMD cpufreq support to acpi-cpufreq Andre Przywara
2012-09-04  8:28 ` [PATCH 1/8 v2] acpi-cpufreq: Add support for modern AMD CPUs Andre Przywara
2012-09-04  8:28 ` [PATCH 2/8 v2] acpi-cpufreq: Add quirk to disable _PSD usage on all " Andre Przywara
     [not found]   ` <>
2012-09-17  7:41     ` Andre Przywara
2012-09-17 11:40       ` Thomas Renninger
2012-09-04  8:28 ` [PATCH 3/8 v2] cpufreq: Add warning message to powernow-k8 Andre Przywara
2012-09-04  8:28 ` [PATCH 4/8 v2] powernow-k8: delay info messages until initialization has succeeded Andre Przywara
2012-09-04  8:28 ` [PATCH 5/8 v2] ACPI: Add fixups for AMD P-state figures Andre Przywara
2012-09-04  8:28 ` [PATCH 6/8 v2] acpi-cpufreq: Add support for disabling dynamic overclocking Andre Przywara
2012-09-04  8:28 ` [PATCH 7/8 v2] acpi-cpufreq: Add compatibility for legacy AMD cpb sysfs knob Andre Przywara
2012-09-04  8:28 ` [PATCH 8/8 v2] cpufreq: Remove support for hardware P-state chips from powernow-k8 Andre Przywara
2012-09-05 13:46 ` [PATCH 0/8 v2] acpi-cpufreq: Move modern AMD cpufreq support to acpi-cpufreq Rafael J. Wysocki
2012-09-05 14:25   ` Thomas Renninger [this message]
2012-09-05 15:05     ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).