From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759198Ab2IETNa (ORCPT ); Wed, 5 Sep 2012 15:13:30 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:54402 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754643Ab2IETN3 (ORCPT ); Wed, 5 Sep 2012 15:13:29 -0400 Date: Wed, 5 Sep 2012 20:13:12 +0100 From: Russell King - ARM Linux To: Arnd Bergmann Cc: Catalin Marinas , linux-arch@vger.kernel.org, Marc Zyngier , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 20/31] arm64: User access library function Message-ID: <20120905191312.GH24085@n2100.arm.linux.org.uk> References: <1344966752-16102-1-git-send-email-catalin.marinas@arm.com> <1344966752-16102-21-git-send-email-catalin.marinas@arm.com> <201208151449.54834.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201208151449.54834.arnd@arndb.de> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 15, 2012 at 02:49:54PM +0000, Arnd Bergmann wrote: > It's fairly unusual to have out of line get_user/put_user functions. > What is the reason for this, other than copying from ARM? Actually, we never used to out of line on ARM, and then I experimented, and found there was a net benefit - not only in code size but also there appeared to be a performance benefit by out of lining them.