linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Glauber Costa <glommer@parallels.com>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	linux-mm@kvack.org, Dave Jones <davej@redhat.com>,
	Ben Hutchings <ben@decadent.org.uk>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Turner <pjt@google.com>,
	Lennart Poettering <lennart@poettering.net>,
	Kay Sievers <kay.sievers@vrfy.org>,
	Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v2] memcg: first step towards hierarchical controller
Date: Wed, 5 Sep 2012 13:12:38 -0700	[thread overview]
Message-ID: <20120905201238.GE13737@google.com> (raw)
In-Reply-To: <20120905144942.GH5388@dhcp22.suse.cz>

Hello, Michal.

On Wed, Sep 05, 2012 at 04:49:42PM +0200, Michal Hocko wrote:
> Can we settle on the following 3 steps?
> 1) warn about "flat" hierarchies (give it X releases) - I will push it
>    to as many Suse code streams as possible (hope other distributions
>    could do the same)

I think I'm just gonna trigger WARN from cgroup core if anyone tries
to create hierarchy with a controller which doesn't support full
hierarchy.  WARN_ON_ONCE() at first and then WARN_ON() on each
creation later on.

> 2) flip the default on the root cgroup & warn when somebody tries to
>    change it to 0 (give it another X releases) that the knob will be
>    removed
> 3) remove the knob and the whole nonsese
> 4) revert 3 if somebody really objects

If we can get to 3, I don't think 4 would be a problem.

Thanks.

-- 
tejun

  reply	other threads:[~2012-09-05 20:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03 15:46 [PATCH v2] memcg: first step towards hierarchical controller Glauber Costa
2012-09-03 16:41 ` Ben Hutchings
2012-09-04  8:29   ` Glauber Costa
2012-09-03 17:08 ` Michal Hocko
2012-09-04  8:34   ` Glauber Costa
2012-09-04 13:09     ` Michal Hocko
2012-09-04 13:27       ` Glauber Costa
2012-09-04 14:35         ` Michal Hocko
2012-09-04 14:37           ` Glauber Costa
2012-09-04 14:54             ` Michal Hocko
2012-09-04 14:54               ` Glauber Costa
2012-09-04 16:25                 ` Michal Hocko
2012-09-05  8:14                   ` Glauber Costa
2012-09-05 14:49                     ` Michal Hocko
2012-09-05 20:12                       ` Tejun Heo [this message]
2012-09-06 12:06                         ` Michal Hocko
2012-09-06 12:09                           ` Glauber Costa
2012-09-06 12:18                             ` Michal Hocko
2012-09-07  9:45                               ` Glauber Costa
2012-09-04 18:22           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120905201238.GE13737@google.com \
    --to=tj@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ben@decadent.org.uk \
    --cc=cgroups@vger.kernel.org \
    --cc=davej@redhat.com \
    --cc=glommer@parallels.com \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kay.sievers@vrfy.org \
    --cc=lennart@poettering.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=pjt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).