From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757213Ab2IFJZT (ORCPT <rfc822;w@1wt.eu>);
	Thu, 6 Sep 2012 05:25:19 -0400
Received: from mail-pb0-f46.google.com ([209.85.160.46]:38242 "EHLO
	mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754712Ab2IFJZR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 6 Sep 2012 05:25:17 -0400
Date: Thu, 6 Sep 2012 02:25:12 -0700
From: Kent Overstreet <koverstreet@google.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-blk: Fix kconfig option
Message-ID: <20120906092512.GB5902@koverstreet-glaptop>
References: <20120903044133.GA9980@moria.home.lan>
 <87wr0ae26e.fsf@rustcorp.com.au>
 <20120906074113.GA5902@koverstreet-glaptop>
 <20120906084403.GD17656@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120906084403.GD17656@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 06, 2012 at 11:44:03AM +0300, Michael S. Tsirkin wrote:
> On Thu, Sep 06, 2012 at 12:41:13AM -0700, Kent Overstreet wrote:
> > On Tue, Sep 04, 2012 at 03:53:53PM +0930, Rusty Russell wrote:
> > > Kent Overstreet <koverstreet@google.com> writes:
> > > 
> > > > CONFIG_VIRTIO isn't exposed, everything else is supposed to select it
> > > > instead.
> > > 
> > > This is a slight mis-understanding.  It's supposed to be selected by
> > > the particular driver, probably virtio_pci in your case.
> > 
> > So are you saying virtio-blk depends on virtio-pci? If so, the kconfig
> > should have that.
> > 
> > As is, VIRTIO_BLK just has:
> > 	depends on EXPERIMENTAL && VIRTIO
> > 
> > which is flat out broken.
> 
> I don't think anything is broken.
> Can you show an example of a broken configuration?

Do you not understand the difference between depends an selects? Or did
you not read my original mail?

Flip off everything in drivers -> virtio

Now go to drivers -> block and try to turn on virtio-blk.

It's not listed!

Now go back to drivers -> virtio and turn on (randomly) balloon.

Go back to drivers -> block, and now you can turn on virtio-blk!

Do you see what's wrong with this picture?