From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751544Ab2IFLsm (ORCPT ); Thu, 6 Sep 2012 07:48:42 -0400 Received: from zoneX.GCU-Squad.org ([194.213.125.0]:1519 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792Ab2IFLsl (ORCPT ); Thu, 6 Sep 2012 07:48:41 -0400 Date: Thu, 6 Sep 2012 13:48:30 +0200 From: Jean Delvare To: LKML Cc: Finn Thain , Geert Uytterhoeven Subject: [PATCH] swim: Add missing spinlock init Message-ID: <20120906134830.52cbdfec@endymion.delvare> X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.7; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It doesn't seem this spinlock was properly initialized. Signed-off-by: Jean Delvare Cc: Finn Thain Cc: Geert Uytterhoeven --- I can't even build-test this. drivers/block/swim.c | 1 + 1 file changed, 1 insertion(+) --- linux-3.6-rc4.orig/drivers/block/swim.c 2012-07-21 22:58:29.000000000 +0200 +++ linux-3.6-rc4/drivers/block/swim.c 2012-09-06 13:09:26.713382169 +0200 @@ -845,6 +845,7 @@ static int __devinit swim_floppy_init(st swd->unit[drive].swd = swd; } + spin_lock_init(&swd->lock); swd->queue = blk_init_queue(do_fd_request, &swd->lock); if (!swd->queue) { err = -ENOMEM; -- Jean Delvare