From: Shawn Guo <shawn.guo@linaro.org>
To: Huang Shijie <shijie8@gmail.com>
Cc: gregkh@linuxfoundation.org, alan@linux.intel.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] serial: mxs-auart: fix the wrong setting order
Date: Fri, 7 Sep 2012 10:38:44 +0800 [thread overview]
Message-ID: <20120907023841.GF26709@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <1346985521-2248-1-git-send-email-shijie8@gmail.com>
On Thu, Sep 06, 2012 at 10:38:40PM -0400, Huang Shijie wrote:
> After set the AUART_CTRL0_CLKGATE, the UART will gate all the clocks off.
> So the following line will not take effect.
> ................................................................
> writel(AUART_INTR_RXIEN | AUART_INTR_RTIEN | AUART_INTR_CTSMIEN,
> u->membase + AUART_INTR_CLR);
> ................................................................
>
> To fix this issue, the patch moves this gate-off line to
> the end of setting registers.
>
> Signed-off-by: Huang Shijie <shijie8@gmail.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Are you experiencing any user visible problem with this bug?
Regards,
Shawn
> ---
> drivers/tty/serial/mxs-auart.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c
> index dafeef2..ea5f888 100644
> --- a/drivers/tty/serial/mxs-auart.c
> +++ b/drivers/tty/serial/mxs-auart.c
> @@ -457,11 +457,11 @@ static void mxs_auart_shutdown(struct uart_port *u)
>
> writel(AUART_CTRL2_UARTEN, u->membase + AUART_CTRL2_CLR);
>
> - writel(AUART_CTRL0_CLKGATE, u->membase + AUART_CTRL0_SET);
> -
> writel(AUART_INTR_RXIEN | AUART_INTR_RTIEN | AUART_INTR_CTSMIEN,
> u->membase + AUART_INTR_CLR);
>
> + writel(AUART_CTRL0_CLKGATE, u->membase + AUART_CTRL0_SET);
> +
> clk_disable_unprepare(s->clk);
> }
>
> --
> 1.7.4.4
>
next prev parent reply other threads:[~2012-09-07 2:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 2:38 [PATCH 1/2] serial: mxs-auart: fix the wrong setting order Huang Shijie
2012-09-07 2:38 ` [PATCH 2/2] serial: mxs-auart: put the device in mxs_auart_probe() Huang Shijie
2012-09-07 2:43 ` Shawn Guo
2012-09-07 2:33 ` [PATCH] serial: mxs-auart: put the device when exit or error Huang Shijie
2012-09-07 3:14 ` Shawn Guo
2012-09-10 23:00 ` Greg KH
2012-09-07 2:48 ` [PATCH 2/2] serial: mxs-auart: put the device in mxs_auart_probe() Huang Shijie
2012-09-07 2:38 ` Shawn Guo [this message]
2012-09-07 2:43 ` [PATCH 1/2] serial: mxs-auart: fix the wrong setting order Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907023841.GF26709@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).