From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
linus.walleij@stericsson.com
Subject: Re: [PATCH 00/19] First HREF Device Tree enablement patch-set
Date: Fri, 7 Sep 2012 14:01:16 +0100 [thread overview]
Message-ID: <20120907130114.GF29601@gmail.com> (raw)
In-Reply-To: <201209071241.17198.arnd@arndb.de>
On Fri, Sep 07, 2012 at 12:41:16PM +0000, Arnd Bergmann wrote:
> On Friday 07 September 2012, Lee Jones wrote:
> > Based on v3.6-rc4
> >
> > This patch consists of Device Tree related enablement for
> > ST-Ericsson's development HREF hardware reference board.
> > Most devices are very similar, if not the same to the
> > previously enabled Snowball low-cost development board.
> > These are referenced from the relevant .dtsi file and
> > merely enabled in the HREF specific Device Tree. There
> > are also one or two minor Device Tree related fixes which
> > were stumbled upon along the way.
>
> The patches basically look good to me (except patch 15, see
> comment there), but they are not ordered in a way that allows
> bisection. I can see two ways to do this better:
>
> a) first do all the code changes, one by one, then add the
> fully populated device tree in the last patch.
>
> b) as commented on patch 5, atomically change over each
> device in both the DT source and the board code.
> Also do the driver changes (i2c, tc3589x) before changing
> them in the device tree.
Just running this by you, as there is method in the madness.
Linus wanted to keep changes to the Device Tree and changes
in platform code separate, which is my reason for submitting
all of my changes to date that way.
What I do (not sure if I've achieved that here yet, I'll need
to take another look) is; make changes to the driver which
enable it for Device Tree use. Then apply the DT node and remove
platform registration in two subsequent patches respectively.
Then when we come to bisect and land in between them we still
have a perfectly working driver, only the second probe fails
which the only side-effect is some warnings in the boot log.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-09-07 13:01 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 11:14 [PATCH 00/19] First HREF Device Tree enablement patch-set Lee Jones
2012-09-07 11:14 ` [PATCH 01/19] ARM: ux500: Add skeleton Device Tree for the HREF reference board Lee Jones
2012-09-10 8:47 ` Linus Walleij
2012-09-14 9:37 ` Lee Jones
2012-09-14 14:01 ` Linus Walleij
2012-09-07 11:14 ` [PATCH 02/19] ARM: ux500: Add UART support to the HREF Device Tree Lee Jones
2012-09-10 8:49 ` Linus Walleij
2012-09-07 11:14 ` [PATCH 03/19] ARM: ux500: Pass SDI DMA information though AUX_DATA to MMCI Lee Jones
2012-09-10 8:50 ` Linus Walleij
2012-09-07 11:14 ` [PATCH 04/19] ARM: ux500: Add SDI (MMC) support to the HREF Device Tree Lee Jones
2012-09-07 12:29 ` Arnd Bergmann
2012-09-07 12:39 ` Lee Jones
2012-09-10 9:51 ` Linus Walleij
2012-09-07 11:14 ` [PATCH 05/19] ARM: ux500: Stop registering HREF's SDI devices from platform data Lee Jones
2012-09-07 12:30 ` Arnd Bergmann
2012-09-07 11:14 ` [PATCH 06/19] ARM: ux500: Add nodes for the MSP into the HREF Device Tree Lee Jones
2012-09-10 9:53 ` Linus Walleij
2012-09-14 9:23 ` Lee Jones
2012-09-14 14:00 ` Linus Walleij
2012-09-07 11:14 ` [PATCH 07/19] ARM: ux500: Add all encompassing sound node to " Lee Jones
2012-09-10 9:56 ` Linus Walleij
2012-09-14 9:20 ` Lee Jones
2012-09-07 11:14 ` [PATCH 08/19] ARM: ux500: Stop registering Audio devices for HREF when DT is enabled Lee Jones
2012-09-10 9:57 ` Linus Walleij
2012-09-07 11:14 ` [PATCH 09/19] ARM: ux500: Enable SSP (SPI) for HREF when booting Device Tree Lee Jones
2012-09-10 11:11 ` Linus Walleij
2012-09-14 9:18 ` Lee Jones
2012-09-17 17:03 ` Roland Stigge
2012-09-18 12:08 ` Linus Walleij
2012-09-18 12:13 ` Roland Stigge
2012-09-07 11:14 ` [PATCH 10/19] ARM: ux500: Remove redundant #gpio-cell properties from HREF and Snowball DT Lee Jones
2012-09-10 11:12 ` Linus Walleij
2012-09-14 9:10 ` Lee Jones
2012-09-14 13:58 ` Linus Walleij
2012-09-07 11:14 ` [PATCH 11/19] ARM: ux500: Add all known I2C sub-device nodes to the HREF DT Lee Jones
2012-09-10 11:34 ` Linus Walleij
2012-09-14 8:47 ` Lee Jones
2012-09-20 6:51 ` Linus Walleij
2012-09-18 15:49 ` Lee Jones
2012-09-07 11:14 ` [PATCH 12/19] i2c-nomadik: Register sub-devices when passed via Device Tree Lee Jones
2012-09-10 11:42 ` Linus Walleij
2012-09-12 10:52 ` Wolfram Sang
2012-09-14 8:27 ` Lee Jones
2012-09-14 8:41 ` Wolfram Sang
2012-09-14 9:02 ` Lee Jones
2012-09-14 9:39 ` Wolfram Sang
2012-09-14 10:15 ` Lee Jones
2012-09-14 11:32 ` Wolfram Sang
2012-09-19 20:12 ` Lee Jones
2012-10-06 11:25 ` Wolfram Sang
2012-09-14 8:22 ` Lee Jones
2012-09-07 11:14 ` [PATCH 13/19] ARM: ux500: Stop registering I2C sub-devices for HREF when DT is enabled Lee Jones
2012-09-10 12:56 ` Linus Walleij
2012-09-07 11:14 ` [PATCH 14/19] ARM: ux500: Apply tc3589x's GPIO/IRQ properties to HREF's DT Lee Jones
2012-09-10 12:58 ` Linus Walleij
2012-09-14 8:33 ` Lee Jones
2012-09-07 11:14 ` [PATCH 15/19] mfd: Don't convert just one IRQ using irqdomain if a range is provided Lee Jones
2012-09-07 12:35 ` Arnd Bergmann
2012-09-07 12:46 ` Lee Jones
2012-09-07 13:37 ` Arnd Bergmann
2012-09-07 13:43 ` Lee Jones
2012-09-07 13:57 ` Arnd Bergmann
2012-09-17 13:45 ` Samuel Ortiz
2012-09-17 14:11 ` Lee Jones
2012-09-21 22:20 ` Samuel Ortiz
2012-09-07 11:14 ` [PATCH 16/19] mfd: Provide the tc3589x with its own IRQ domain Lee Jones
2012-09-10 13:05 ` Linus Walleij
2012-09-16 23:45 ` Samuel Ortiz
2012-09-07 11:14 ` [PATCH 17/19] mfd: Enable the tc3589x for Device Tree Lee Jones
2012-09-10 13:08 ` Linus Walleij
2012-09-16 23:45 ` Samuel Ortiz
2012-09-07 11:14 ` [PATCH 18/19] gpio: Provide the tc3589x GPIO expander driver with an IRQ domain Lee Jones
2012-09-10 13:10 ` Linus Walleij
2012-09-12 13:04 ` Linus Walleij
2012-09-14 8:14 ` Lee Jones
2012-09-12 21:21 ` Linus Walleij
2012-09-07 11:14 ` [PATCH 19/19] gpio: Enable the tc3298x GPIO expander driver for Device Tree Lee Jones
2012-09-10 13:20 ` Linus Walleij
2012-09-12 21:21 ` Linus Walleij
2012-09-07 12:41 ` [PATCH 00/19] First HREF Device Tree enablement patch-set Arnd Bergmann
2012-09-07 13:01 ` Lee Jones [this message]
2012-09-07 13:58 ` Arnd Bergmann
2012-09-07 14:22 ` Lee Jones
2012-09-10 8:41 ` Linus Walleij
2012-09-10 10:13 ` Arnd Bergmann
2012-09-10 11:29 ` Linus Walleij
2012-09-10 13:49 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907130114.GF29601@gmail.com \
--to=lee.jones@linaro.org \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=arnd@arndb.de \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).