From: Mike Turquette <mturquette@linaro.org>
To: Murali Karicheri <m-karicheri2@ti.com>,
<linux-kernel@vger.kernel.org>,
<spi-devel-general@lists.sourceforge.net>,
<grant.likely@secretlab.ca>
Cc: Murali Karicheri <m-karicheri2@ti.com>
Subject: Re: [PATCH] spi:clk: preparation for switch to common clock framework
Date: Fri, 07 Sep 2012 14:28:13 -0700 [thread overview]
Message-ID: <20120907212813.20289.53844@nucleus> (raw)
In-Reply-To: <1346351121-27710-1-git-send-email-m-karicheri2@ti.com>
Quoting Murali Karicheri (2012-08-30 11:25:21)
> As a first step towards migrating davinci platforms to use common clock
> framework, replace all instances of clk_enable() with clk_prepare_enable()
> and clk_disable() with clk_disable_unprepare(). Until the platform is
> switched to use the CONFIG_HAVE_CLK_PREPARE Kconfig variable, this just
> adds a might_sleep() call and would work without any issues.
>
> This will make it easy later to switch to common clk based implementation
> of clk driver from DaVinci specific driver.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Acked-by: Mike Turquette <mturquette@linaro.org>
> ---
> drivers/spi/spi-davinci.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
> index 9b2901f..71a6423 100644
> --- a/drivers/spi/spi-davinci.c
> +++ b/drivers/spi/spi-davinci.c
> @@ -873,7 +873,7 @@ static int __devinit davinci_spi_probe(struct platform_device *pdev)
> ret = -ENODEV;
> goto put_master;
> }
> - clk_enable(dspi->clk);
> + clk_prepare_enable(dspi->clk);
>
> master->bus_num = pdev->id;
> master->num_chipselect = pdata->num_chipselect;
> @@ -959,7 +959,7 @@ free_dma:
> edma_free_channel(dspi->dma.rx_channel);
> edma_free_slot(dspi->dma.dummy_param_slot);
> free_clk:
> - clk_disable(dspi->clk);
> + clk_disable_unprepare(dspi->clk);
> clk_put(dspi->clk);
> put_master:
> spi_master_put(master);
> @@ -995,7 +995,7 @@ static int __devexit davinci_spi_remove(struct platform_device *pdev)
>
> spi_bitbang_stop(&dspi->bitbang);
>
> - clk_disable(dspi->clk);
> + clk_disable_unprepare(dspi->clk);
> clk_put(dspi->clk);
> spi_master_put(master);
> free_irq(dspi->irq, dspi);
> --
> 1.7.9.5
prev parent reply other threads:[~2012-09-07 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1346351121-27710-1-git-send-email-m-karicheri2@ti.com>
2012-09-07 18:37 ` [PATCH] spi:clk: preparation for switch to common clock framework Karicheri, Muralidharan
2012-09-07 21:28 ` Mike Turquette [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907212813.20289.53844@nucleus \
--to=mturquette@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).