From: Greg KH <gregkh@linuxfoundation.org>
To: Bruce Humphrey <brucehum@gmail.com>
Cc: abbotti@mev.co.uk, fmhess@users.sourceforge.net,
hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: drivers: fl512: change printk(KERN_INFO ... for the prefered pr_info(...
Date: Mon, 10 Sep 2012 19:52:52 -0700 [thread overview]
Message-ID: <20120911025252.GA28112@kroah.com> (raw)
In-Reply-To: <1347331815-7278-1-git-send-email-brucehum@gmail.com>
On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> Change 5 instances of printk(KERN_INFO, KERN_WARN and KERN_ERROR for the prefered pr_info, pr_warn and pr_error
>
> Signed-off-by: Bruce Humphrey Ventura <brucehum@gmail.com>
> ---
> drivers/staging/comedi/drivers/fl512.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c
> index d1da809..258a7b4 100644
> --- a/drivers/staging/comedi/drivers/fl512.c
> +++ b/drivers/staging/comedi/drivers/fl512.c
> @@ -118,9 +118,9 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> struct comedi_subdevice *s;
>
> iobase = it->options[0];
> - printk(KERN_INFO "comedi:%d fl512: 0x%04lx", dev->minor, iobase);
> + pr_info("comedi:%d fl512: 0x%04lx", dev->minor, iobase);
Why can't you use dev_info() here, and in other places? You should use
the dev_* functions instead of pr_* wherever possible.
thanks,
greg k-h
next prev parent reply other threads:[~2012-09-11 2:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 2:50 [PATCH] Staging: comedi: drivers: fl512: change printk(KERN_INFO ... for the prefered pr_info( Bruce Humphrey
2012-09-11 2:52 ` Greg KH [this message]
2012-09-11 3:40 ` Joe Perches
2012-09-11 3:44 ` Greg KH
2012-09-11 3:48 ` Joe Perches
2012-09-11 11:02 ` Dan Carpenter
2012-09-11 15:19 ` [PATCH] checkpatch: Update suggested printk conversions Joe Perches
2012-09-11 10:59 ` [PATCH] Staging: comedi: drivers: fl512: change printk(KERN_INFO ... for the prefered pr_info( Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911025252.GA28112@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=brucehum@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).