From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753100Ab2IKIuG (ORCPT ); Tue, 11 Sep 2012 04:50:06 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:47749 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751616Ab2IKIuE (ORCPT ); Tue, 11 Sep 2012 04:50:04 -0400 Date: Tue, 11 Sep 2012 11:49:29 +0300 From: Dan Carpenter To: Samuel Iglesias =?iso-8859-1?Q?Gons=E1lvez?= Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, industrypack-devel@lists.sourceforge.net Subject: Re: [PATCH 11/20] Staging: ipack/bridges/tpci200: reorder the iounmap and pci_release_region Message-ID: <20120911084929.GR19396@mwanda> References: <1347267118-9580-1-git-send-email-siglesias@igalia.com> <1347267118-9580-11-git-send-email-siglesias@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1347267118-9580-11-git-send-email-siglesias@igalia.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2012 at 10:51:49AM +0200, Samuel Iglesias Gonsálvez wrote: > Signed-off-by: Samuel Iglesias Gonsálvez The change log says what you are doing (although it's not 100% accurate), but it doesn't say why. I assume this is a bugfix as well? Please describe the user visible effects of this change in the changelog. regards, dan carpenter