From: Samuel Ortiz <sameo@linux.intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: core: Push irqdomain mapping out into devices
Date: Tue, 11 Sep 2012 12:16:43 +0200 [thread overview]
Message-ID: <20120911101643.GM3647@sortiz-mobl> (raw)
In-Reply-To: <1347347796-26925-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Hi Mark, Lee,
On Tue, Sep 11, 2012 at 03:16:36PM +0800, Mark Brown wrote:
> Currently the MFD core supports remapping MFD cell interrupts using an
> irqdomain but only if the MFD is being instantiated using device tree
> and only if the device tree bindings use the pattern of registering IPs
> in the device tree with compatible properties. This will be actively
> harmful for drivers which support non-DT platforms and use this pattern
> for their DT bindings as it will mean that the core will silently change
> remapping behaviour and it is also limiting for drivers which don't do
> DT with this particular pattern. There is also a potential fragility if
> there are interrupts not associated with MFD cells and all the cells are
> omitted from the device tree for some reason.
>
> Instead change the code to take an IRQ domain as an optional argument,
> allowing drivers to take the decision about the parent domain for their
> interrupts. The one current user of this feature is ab8500-core, it has
> the domain lookup pushed out into the driver.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>
> This should incorporate a fix Lee Jones created for ab8500, though he
> was only able to describe it verbally and not send a patch so I'd like
> some confirmation from him that it's OK.
I'm applying this one to my for-linus branch and I'd like to send a pull
request to Linus in a few days. Lee, could you please confirm that it's OK
with you ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2012-09-11 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 7:16 [PATCH] mfd: core: Push irqdomain mapping out into devices Mark Brown
2012-09-11 10:16 ` Samuel Ortiz [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-21 19:01 Mark Brown
2012-08-21 18:20 Mark Brown
2012-08-21 18:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911101643.GM3647@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).