From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758793Ab2IKK4S (ORCPT ); Tue, 11 Sep 2012 06:56:18 -0400 Received: from zoneX.GCU-Squad.org ([194.213.125.0]:11803 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758661Ab2IKK4R (ORCPT ); Tue, 11 Sep 2012 06:56:17 -0400 Date: Tue, 11 Sep 2012 12:56:08 +0200 From: Jean Delvare To: Samuel Ortiz Cc: LKML , Grant Likely , Peter Tyser , Aaron Sierra Subject: Re: [PATCH] gpio-ich: Share ownership of GPIO groups Message-ID: <20120911125608.385356fc@endymion.delvare> In-Reply-To: <20120911104116.GR3647@sortiz-mobl> References: <20120723173415.5b80b28b@endymion.delvare> <20120911104116.GR3647@sortiz-mobl> X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.7; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Sep 2012 12:41:16 +0200, Samuel Ortiz wrote: > Hi Jean, > > On Mon, Jul 23, 2012 at 05:34:15PM +0200, Jean Delvare wrote: > > The ICH chips have their GPIO pins organized in 2 or 3 independent > > groups of 32 GPIO pins. It can happen that the ACPI BIOS wants to make > > use of pins in one group, preventing the OS to access these. This does > > not prevent the OS from accessing the other group(s). > > > > This is the case for example on my Asus Z8NA-D6 board. The ACPI BIOS > > wants to control GPIO 18 (group 1), while I (the OS) need to control > > GPIO 52 and 53 (group 2) for SMBus multiplexing. > > > > So instead of checking for ACPI resource conflict on the whole I/O > > range, check on a per-group basis, and consider it a success if at > > least one of the groups is available for the OS to use. > > > > Signed-off-by: Jean Delvare > > Cc: Peter Tyser > > Cc: Aaron Sierra > > Cc: Grant Likely > > Cc: Samuel Ortiz > > --- > > That's probably not the nicest code you've seen, but everything else I > > could think of either couldn't work or was looking worse. If anyone can > > think of a better approach, I'm all ears. > > > > drivers/gpio/gpio-ich.c | 79 +++++++++++++++++++++++++++++++++++++------ > > drivers/mfd/lpc_ich.c | 29 ++++++++++++++- > > include/linux/mfd/lpc_ich.h | 1 > > 3 files changed, 97 insertions(+), 12 deletions(-) > Applied (finally) to my for-next branch, thanks. Excellent, thank you! -- Jean Delvare