From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758079Ab2IKOGS (ORCPT ); Tue, 11 Sep 2012 10:06:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24444 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753406Ab2IKOGR (ORCPT ); Tue, 11 Sep 2012 10:06:17 -0400 Date: Tue, 11 Sep 2012 16:05:49 +0200 From: Jiri Olsa To: "Yan, Zheng" Cc: eranian@google.com, a.p.zijlstra@chello.nl, mingo@elte.hu, andi@firstfloor.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 3/3] perf tool: Allow wildcard in PMU name Message-ID: <20120911140549.GC3800@krava.brq.redhat.com> References: <1347263631-23175-1-git-send-email-zheng.z.yan@intel.com> <1347263631-23175-4-git-send-email-zheng.z.yan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1347263631-23175-4-git-send-email-zheng.z.yan@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2012 at 03:53:51PM +0800, Yan, Zheng wrote: > From: "Yan, Zheng" > SNIP > +int parse_events_add_pmu(struct list_head **_list, int *idx, > char *name, struct list_head *head_config) > { > struct perf_event_attr attr; > - struct perf_pmu *pmu; > + struct list_head *list; > + struct perf_pmu *pmu = NULL; > + struct perf_evsel *evsel, *first = NULL; > + int orig_idx = *idx; > > - pmu = perf_pmu__find(name); > - if (!pmu) > - return -EINVAL; > + list = malloc(sizeof(*list)); > + if (!list) > + return -ENOMEM; > + INIT_LIST_HEAD(list); list should be allocated only if (!*_list)) same as in add_event function I haven't test, but I think you'll leak/loose events if there's another pmu event defined after ',' jirka