From: Alan Cox <alan@linux.intel.com>
To: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: "Colin Cross" <ccross@android.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Russell King" <linux@arm.linux.org.uk>,
"Jason Wessel" <jason.wessel@windriver.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Brian Swetland" <swetland@google.com>,
"John Stultz" <john.stultz@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org, patches@linaro.org,
kernel-team@android.com, kgdb-bugreport@lists.sourceforge.net,
linux-serial@vger.kernel.org
Subject: Re: [RFC] tty/serial/kgdboc: Add and wire up clear_irqs callback
Date: Wed, 12 Sep 2012 10:44:20 +0100 [thread overview]
Message-ID: <20120912104420.06a88957@bob.linux.org.uk> (raw)
In-Reply-To: <20120912040657.GA3880@lizard>
> Of course, if Alan is OK with this, I'm more than OK too. :-)
It may well be better.
> (But the polling routines would need to clear all interrupts, not
> just rx/tx. For example, if the controller indicated some error, and
> nobody clears it, then we'll start reentering infinitely.)
For a lot of devices and platforms you'd probably mask them instead ?
>
> > If you use a clear_irqs callback, you can drop characters if
> > one arrives between the last character buffer read and calling
> > clear_irqs.
>
> Only if we call clear_irqs() after reading the characters, but we do
> it before. So if new characters are available, we will reenter NMI,
> which is OK.
Recursively or not... again you get platform specific magic in places
we don't want.
In the driver poll method for most uarts is going to be at least buried
in what is usually arch specific uarts.
next prev parent reply other threads:[~2012-09-12 9:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 9:30 [PATCH v6 0/12] KGDB/KDB FIQ (NMI) debugger Anton Vorontsov
2012-09-11 9:34 ` [PATCH 01/12] kernel/debug: Mask KGDB NMI upon entry Anton Vorontsov
2012-09-11 9:34 ` [PATCH 02/12] kdb: Implement disable_nmi command Anton Vorontsov
2012-09-11 9:34 ` [PATCH 03/12] kdb: Turn KGDB_KDB=n stubs into static inlines Anton Vorontsov
2012-09-11 9:34 ` [PATCH 04/12] tty/serial/core: Introduce poll_init callback Anton Vorontsov
2012-09-11 9:34 ` [PATCH 05/12] tty/serial/amba-pl011: Implement " Anton Vorontsov
2012-09-11 9:35 ` [PATCH 06/12] tty/serial/kgdboc: Add and wire up clear_irqs callback Anton Vorontsov
2012-09-11 14:15 ` Alan Cox
2012-09-12 3:32 ` [RFC] " Anton Vorontsov
2012-09-12 3:42 ` Colin Cross
2012-09-12 4:06 ` Anton Vorontsov
2012-09-12 4:40 ` Colin Cross
2012-09-12 7:01 ` Anton Vorontsov
2012-09-12 9:44 ` Alan Cox [this message]
2012-09-12 10:32 ` Anton Vorontsov
2012-09-11 9:35 ` [PATCH 07/12] tty/serial/amba-pl011: Implement " Anton Vorontsov
2012-09-11 9:35 ` [PATCH 08/12] tty/serial: Add kgdb_nmi driver Anton Vorontsov
2012-09-11 14:14 ` Alan Cox
2012-09-12 0:41 ` Anton Vorontsov
2012-09-11 9:35 ` [PATCH 09/12] ARM: Move some macros from entry-armv to entry-header Anton Vorontsov
2012-09-11 9:35 ` [PATCH 10/12] ARM: Add KGDB/KDB FIQ debugger generic code Anton Vorontsov
2012-09-11 9:35 ` [PATCH 11/12] ARM: VIC: Add a couple of low-level FIQ management helpers Anton Vorontsov
2012-09-11 9:35 ` [PATCH 12/12] ARM: versatile: Make able to use UART ports for KGDB FIQ debugger Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912104420.06a88957@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=anton.vorontsov@linaro.org \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=jason.wessel@windriver.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
--cc=swetland@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).