From: Oleg Nesterov <oleg@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: srikar@linux.vnet.ibm.com, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Roland McGrath <roland@hack.frob.com>,
linux-kernel@vger.kernel.org, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] uprobes: add global breakpoints
Date: Wed, 12 Sep 2012 20:12:10 +0200 [thread overview]
Message-ID: <20120912181210.GA11122@redhat.com> (raw)
In-Reply-To: <20120912143010.GA1447@redhat.com>
On 09/12, Oleg Nesterov wrote:
>
> Lets start with the patch below,
> ...
>
> - if (!(uprobe->flags & UPROBE_SKIP_SSTEP))
> + if (!(uprobe->flags & UPROBE_SKIP_SSTEP) || (action & UPROBE_RESTART))
Hmm. This is wrong, but only because handle_swbp() is buggy.
I'll send the fix tomorrow.
Oleg.
prev parent reply other threads:[~2012-09-12 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 15:37 [PATCH 1/2] uprobes: probe definiton can only start with 'p' and '-' Sebastian Andrzej Siewior
2012-09-11 15:37 ` [PATCH 2/2] uprobes: add global breakpoints Sebastian Andrzej Siewior
2012-09-12 14:30 ` Oleg Nesterov
2012-09-12 14:29 ` Peter Zijlstra
2012-09-12 18:12 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912181210.GA11122@redhat.com \
--to=oleg@redhat.com \
--cc=ananth@in.ibm.com \
--cc=bigeasy@linutronix.de \
--cc=gdb-patches@sourceware.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=roland@hack.frob.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).