From: Tejun Heo <tj@kernel.org>
To: Joseph Glanville <joseph.glanville@orionvm.com.au>
Cc: NeilBrown <neilb@suse.de>,
Kent Overstreet <koverstreet@google.com>,
Jens Axboe <axboe@kernel.dk>,
Philipp Reisner <philipp.reisner@linbit.com>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Vivek Goyal <vgoyal@redhat.com>,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] FLUSH/FUA documentation & code discrepancy
Date: Wed, 12 Sep 2012 16:20:19 -0700 [thread overview]
Message-ID: <20120912232019.GW7677@google.com> (raw)
In-Reply-To: <CAOzFzEjCf7ZPbheq-tfhts-E=Ep1kvn0muksaaTFqJ=cMm772w@mail.gmail.com>
On Thu, Sep 13, 2012 at 09:12:25AM +1000, Joseph Glanville wrote:
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 4b4dbdf..68b5671 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -1809,6 +1809,9 @@ EXPORT_SYMBOL(generic_make_request);
> * uses that function to do most of the work. Both are fairly rough
> * interfaces; @bio must be presetup and ready for I/O.
> *
> + * Ordering of requests is not guaranteed, callers should drain the queue
> + * and issue a flush before submission of any dependent bios.
I think using "requests" here is confusing given that struct request
means something else in the block layer. Also, the caller doesn't
have to drain the whole queue but just the ones involved in the
dependency and flush doesn't really matter here although mentioning
that flush too doesn't have any ordering guarantee would be nice.
Also, updating submit_bio() comment too would be nice - something
simple about lack of ordering and then reference to
generic_make_request().
Thanks.
--
tejun
next prev parent reply other threads:[~2012-09-12 23:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 12:32 FLUSH/FUA documentation & code discrepancy Philipp Reisner
2012-09-04 22:46 ` Tejun Heo
2012-09-05 8:44 ` [Drbd-dev] " Philipp Reisner
2012-09-05 8:49 ` Tejun Heo
2012-09-05 10:07 ` Lars Ellenberg
2012-09-06 21:29 ` Tejun Heo
2012-09-07 8:42 ` Lars Ellenberg
2012-09-10 22:54 ` Tejun Heo
2012-09-10 23:06 ` Tejun Heo
2012-09-10 23:12 ` Kent Overstreet
2012-09-10 23:31 ` Kent Overstreet
2012-09-11 5:58 ` NeilBrown
2012-09-11 8:25 ` Lars Ellenberg
2012-09-11 14:41 ` Vivek Goyal
2012-09-12 18:58 ` Tejun Heo
2012-09-12 23:12 ` Joseph Glanville
2012-09-12 23:20 ` Tejun Heo [this message]
2012-09-12 23:53 ` Joseph Glanville
2012-09-13 0:17 ` Joseph Glanville
2012-09-13 3:10 ` Joseph Glanville
2012-09-13 19:25 ` Tejun Heo
2012-09-11 14:34 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912232019.GW7677@google.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@lst.de \
--cc=joseph.glanville@orionvm.com.au \
--cc=koverstreet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=philipp.reisner@linbit.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).