From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 13/20] Input: bcm5974 - Drop pressure and width emulation
Date: Wed, 12 Sep 2012 23:57:24 -0700 [thread overview]
Message-ID: <20120913065723.GH17105@core.coreip.homeip.net> (raw)
In-Reply-To: <1346528835-363-14-git-send-email-rydberg@euromail.se>
On Sat, Sep 01, 2012 at 09:47:08PM +0200, Henrik Rydberg wrote:
> The ABS_PRESSURE and ABS_WIDTH have special scales, and were initially
> added solely for thumb and palm recognition in the synaptics driver.
> This never really get used, however, and userspace quickly moved to
> MT solutions instead. This patch drops the unused events.
How can you know that? There could still be people using ST emulation
with this device. I think we should keep it.
Thanks.
>
> Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
> ---
> drivers/input/mouse/bcm5974.c | 26 +++++---------------------
> 1 file changed, 5 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
> index 2de974c..e033d3a 100644
> --- a/drivers/input/mouse/bcm5974.c
> +++ b/drivers/input/mouse/bcm5974.c
> @@ -417,10 +417,6 @@ static void setup_events_to_report(struct input_dev *input_dev,
> {
> __set_bit(EV_ABS, input_dev->evbit);
>
> - input_set_abs_params(input_dev, ABS_PRESSURE,
> - 0, cfg->p.dim, cfg->p.fuzz, 0);
> - input_set_abs_params(input_dev, ABS_TOOL_WIDTH,
> - 0, cfg->w.dim, cfg->w.fuzz, 0);
> input_set_abs_params(input_dev, ABS_X,
> 0, cfg->x.dim, cfg->x.fuzz, 0);
> input_set_abs_params(input_dev, ABS_Y,
> @@ -504,9 +500,9 @@ static int report_tp_state(struct bcm5974 *dev, int size)
> const struct bcm5974_config *c = &dev->cfg;
> const struct tp_finger *f;
> struct input_dev *input = dev->input;
> - int raw_p, raw_w, raw_x, raw_y, raw_n, i;
> + int raw_p, raw_x, raw_y, raw_n, i;
> int ptest, origin, ibt = 0, nmin = 0, nmax = 0;
> - int abs_p = 0, abs_w = 0, abs_x = 0, abs_y = 0;
> + int abs_x = 0, abs_y = 0;
>
> if (size < c->tp_offset || (size - c->tp_offset) % SIZEOF_FINGER != 0)
> return -EIO;
> @@ -523,22 +519,19 @@ static int report_tp_state(struct bcm5974 *dev, int size)
> report_finger_data(input, c, &f[i]);
>
> raw_p = raw2int(f->touch_major);
> - raw_w = raw2int(f->tool_major);
> raw_x = raw2int(f->abs_x);
> raw_y = raw2int(f->abs_y);
>
> dprintk(9,
> "bcm5974: "
> - "raw: p: %+05d w: %+05d x: %+05d y: %+05d n: %d\n",
> - raw_p, raw_w, raw_x, raw_y, raw_n);
> + "raw: p: %+05d x: %+05d y: %+05d n: %d\n",
> + raw_p, raw_x, raw_y, raw_n);
>
> ptest = int2bound(&c->p, raw_p);
> origin = raw2int(f->origin);
>
> /* while tracking finger still valid, count all fingers */
> if (ptest > PRESSURE_LOW && origin) {
> - abs_p = ptest;
> - abs_w = int2bound(&c->w, raw_w);
> abs_x = int2bound(&c->x, raw_x - c->x.devmin);
> abs_y = int2bound(&c->y, c->y.devmax - raw_y);
> while (raw_n--) {
> @@ -568,18 +561,9 @@ static int report_tp_state(struct bcm5974 *dev, int size)
> input_report_key(input, BTN_TOOL_TRIPLETAP, dev->fingers == 3);
> input_report_key(input, BTN_TOOL_QUADTAP, dev->fingers > 3);
>
> - input_report_abs(input, ABS_PRESSURE, abs_p);
> - input_report_abs(input, ABS_TOOL_WIDTH, abs_w);
> -
> - if (abs_p) {
> + if (dev->fingers > 0) {
> input_report_abs(input, ABS_X, abs_x);
> input_report_abs(input, ABS_Y, abs_y);
> -
> - dprintk(8,
> - "bcm5974: abs: p: %+05d w: %+05d x: %+05d y: %+05d "
> - "nmin: %d nmax: %d n: %d ibt: %d\n", abs_p, abs_w,
> - abs_x, abs_y, nmin, nmax, dev->fingers, ibt);
> -
> }
>
> /* type 2 reports button events via ibt only */
> --
> 1.7.12
>
--
Dmitry
next prev parent reply other threads:[~2012-09-13 6:57 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 19:46 [PATCH v3 v3 00/20] Input and HID updates for 3.7 Henrik Rydberg
2012-09-01 19:46 ` [PATCH v3 01/20] Input: Break out MT data Henrik Rydberg
2012-09-13 5:15 ` Dmitry Torokhov
2012-09-13 17:58 ` Henrik Rydberg
2012-09-01 19:46 ` [PATCH v3 02/20] Input: Improve the events-per-packet estimate Henrik Rydberg
2012-09-13 5:16 ` Dmitry Torokhov
2012-09-01 19:46 ` [PATCH v3 03/20] Input: Make sure we follow all EV_KEY events Henrik Rydberg
2012-09-13 5:19 ` Dmitry Torokhov
2012-09-01 19:46 ` [PATCH v3 04/20] Input: Move autorepeat to the event-passing phase Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 05/20] Input: Send events one packet at a time Henrik Rydberg
2012-09-13 6:56 ` Dmitry Torokhov
2012-09-13 17:59 ` Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 06/20] Input: evdev - Add the events() callback Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 07/20] Input: MT - Add flags to input_mt_init_slots() Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 08/20] Input: MT - Handle frame synchronization in core Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 09/20] Input: MT - Add in-kernel tracking Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 10/20] Input: MT - Get slot by key Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 11/20] Input: bcm5974 - only setup button urb for TYPE1 devices Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 12/20] Input: bcm5974 - Preparatory renames Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 13/20] Input: bcm5974 - Drop pressure and width emulation Henrik Rydberg
2012-09-13 6:57 ` Dmitry Torokhov [this message]
2012-09-13 18:41 ` Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 14/20] Input: bcm5974 - Drop the logical dimensions Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 15/20] Input: bcm5974 - Convert to MT-B Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 16/20] HID: Only dump input if someone is listening Henrik Rydberg
2012-09-02 7:28 ` Jiri Kosina
2012-09-02 8:52 ` Henrik Rydberg
2012-09-03 13:17 ` Jiri Kosina
2012-09-06 20:57 ` Henrik Rydberg
2012-09-07 1:54 ` Ping Cheng
2012-09-07 12:52 ` Jiri Kosina
2012-09-10 19:02 ` Henrik Rydberg
2012-09-10 20:49 ` Jiri Kosina
2012-09-10 21:12 ` Dmitry Torokhov
2012-09-14 19:25 ` Henrik Rydberg
2012-09-15 15:33 ` Input and HID updates for 3.7, version 4 Henrik Rydberg
2012-09-18 11:29 ` Jiri Kosina
2012-09-18 16:19 ` Henrik Rydberg
2012-09-19 16:57 ` Dmitry Torokhov
2012-09-19 18:34 ` Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 17/20] HID: Add an input configured notification callback Henrik Rydberg
2012-09-01 19:47 ` Henrik Rydberg
2012-09-01 19:47 ` [PATCH v3 19/20] HID: hid-multitouch: Remove the redundant touch state Henrik Rydberg
2012-09-01 19:47 ` [PATCH 20/20] HID: hid-multitouch: Add missing contact count detection Henrik Rydberg
2012-09-03 12:59 ` Benjamin Tissoires
2012-09-03 17:07 ` Henrik Rydberg
2012-09-05 15:09 ` [PATCH v2 20/20] HID: hid-multitouch: Fix contact count on 3M panels Henrik Rydberg
2012-09-03 13:00 ` [PATCH v3 v3 00/20] Input and HID updates for 3.7 Benjamin Tissoires
2012-09-03 17:08 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913065723.GH17105@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).